hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Miklos Csanady <miklos.csan...@cloudera.com>
Subject Re: Review Request 51287: The ConsoleReader.readLine method never echoes back the executed line. Instead, Beeline.info is used, which is redirected to stderr with other messages. On interactive mode both outputs are visible.
Date Tue, 23 Aug 2016 07:19:06 GMT


> On Aug. 23, 2016, 12:34 a.m., Sergio Pena wrote:
> > Could you paste the test you made for this patch? like before & after the patch
output?

I have discovered that it breaks some of the tests  in org.apache.beeline.cli.TestHiveCli.java.

Now I try to investigate this and modify them if it seems to be the best solution.


- Miklos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51287/#review146463
-----------------------------------------------------------


On Aug. 22, 2016, 5:40 p.m., Miklos Csanady wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51287/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 5:40 p.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-14525
>     https://issues.apache.org/jira/browse/HIVE-14525
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14525: beeline still writing log data to stdout as of version 2.1.0
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java e0fa032 
> 
> Diff: https://reviews.apache.org/r/51287/diff/
> 
> 
> Testing
> -------
> 
> Beeline with redirected input and output with script file and without one.
> 
> 
> Thanks,
> 
> Miklos Csanady
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message