hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vineet Garg <vg...@hortonworks.com>
Subject Re: Review Request 51006: CBO: Return path - Fix for converting GroupBy operator with no map side group by
Date Fri, 12 Aug 2016 18:18:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51006/
-----------------------------------------------------------

(Updated Aug. 12, 2016, 6:18 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-14396
    https://issues.apache.org/jira/browse/HIVE-14396


Repository: hive-git


Description
-------

This patch fixes the following issues:
1. UDAF info collection was looking for wrong expression for a UDAF's parameter from HiveAggregate.
2. Converting HiveAggregate to GroupBy operator was creating wrong expressions for UDAF's
arguments based on underlying Reduce operator.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 774fc59 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java
25fe059 
  ql/src/test/queries/clientpositive/count.q 41ffaf2 
  ql/src/test/queries/clientpositive/groupby_ppr_multi_distinct.q 74bd2fd 
  ql/src/test/results/clientpositive/count.q.out c950c5b 
  ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out 33d1ed0 
  ql/src/test/results/clientpositive/spark/count.q.out b1ad662 
  ql/src/test/results/clientpositive/spark/groupby_ppr_multi_distinct.q.out 5251241 
  ql/src/test/results/clientpositive/tez/count.q.out 9fc2c75 

Diff: https://reviews.apache.org/r/51006/diff/


Testing
-------

Added new tests and Pre-commit testing


Thanks,

Vineet Garg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message