hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 51006: CBO: Return path - Fix for converting GroupBy operator with no map side group by
Date Fri, 12 Aug 2016 16:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51006/#review145627
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java (line
727)
<https://reviews.apache.org/r/51006/#comment211930>

    Can you add a comment for this?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java 
<https://reviews.apache.org/r/51006/#comment211931>

    This comment is useful, instead of deleting this comment, its better to update it.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java (line
1083)
<https://reviews.apache.org/r/51006/#comment211934>

    Can you add comment for when this condition is going to be true?


- Ashutosh Chauhan


On Aug. 11, 2016, 8:55 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51006/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 8:55 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-14396
>     https://issues.apache.org/jira/browse/HIVE-14396
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch fixes the following issues:
> 1. UDAF info collection was looking for wrong expression for a UDAF's parameter from
HiveAggregate.
> 2. Converting HiveAggregate to GroupBy operator was creating wrong expressions for UDAF's
arguments based on underlying Reduce operator.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 774fc59

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java
25fe059 
>   ql/src/test/queries/clientpositive/count.q 41ffaf2 
>   ql/src/test/queries/clientpositive/groupby_ppr_multi_distinct.q 74bd2fd 
>   ql/src/test/results/clientpositive/count.q.out c950c5b 
>   ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out 33d1ed0 
>   ql/src/test/results/clientpositive/spark/count.q.out b1ad662 
>   ql/src/test/results/clientpositive/spark/groupby_ppr_multi_distinct.q.out 5251241 
>   ql/src/test/results/clientpositive/tez/count.q.out 9fc2c75 
> 
> Diff: https://reviews.apache.org/r/51006/diff/
> 
> 
> Testing
> -------
> 
> Added new tests and Pre-commit testing
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message