hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajesh Balamohan <rajesh.balamo...@gmail.com>
Subject Re: Review Request 50888: Reduce number of partition check calls in add_partitions
Date Tue, 09 Aug 2016 00:22:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50888/
-----------------------------------------------------------

(Updated Aug. 9, 2016, 12:22 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

addedPartitions.put() was needed so that it can be rolledback on need basis.


Bugs: HIVE-14462
    https://issues.apache.org/jira/browse/HIVE-14462


Repository: hive-git


Description
-------

Metastore already does all the validations. Lots of MS calls are made just before add_partitions
to double check if the partitions exists.  This impacts perf when large number of partitions
are present.


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 38c0eed 

Diff: https://reviews.apache.org/r/50888/diff/


Testing
-------


Thanks,

Rajesh Balamohan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message