Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1589200B43 for ; Tue, 19 Jul 2016 22:03:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CEB40160A76; Tue, 19 Jul 2016 20:03:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2100B160A5C for ; Tue, 19 Jul 2016 22:03:54 +0200 (CEST) Received: (qmail 74977 invoked by uid 500); 19 Jul 2016 20:03:54 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 74961 invoked by uid 99); 19 Jul 2016 20:03:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jul 2016 20:03:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 408BD27D93F; Tue, 19 Jul 2016 20:03:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6038947242201742107==" MIME-Version: 1.0 Subject: Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time From: Hari Sankar Sivarama Subramaniyan To: Ashutosh Chauhan Cc: Hari Sankar Sivarama Subramaniyan , hive Date: Tue, 19 Jul 2016 20:03:53 -0000 Message-ID: <20160719200353.15321.67840@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Hari Sankar Sivarama Subramaniyan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49965/ X-Sender: Hari Sankar Sivarama Subramaniyan References: <20160719200158.15321.49517@reviews.apache.org> In-Reply-To: <20160719200158.15321.49517@reviews.apache.org> Reply-To: Hari Sankar Sivarama Subramaniyan X-ReviewRequest-Repository: hive-git archived-at: Tue, 19 Jul 2016 20:03:56 -0000 --===============6038947242201742107== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/#review142821 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java (line 275) This should be (partNames == null || partNames.size() > 0) - Hari Sankar Sivarama Subramaniyan On July 19, 2016, 8:01 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49965/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 8:01 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java da2e1e2 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 > > Diff: https://reviews.apache.org/r/49965/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > > --===============6038947242201742107==--