Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============9204463921881352291=="
MIME-Version: 1.0
Subject: Re: Review Request 49498: HIVE-14123: Add beeline configuration
 option to show database in the prompt
From: Aihua Xu <axu@cloudera.com>
To: Vihang Karajgaonkar <vihang@cloudera.com>, Szehon Ho <szehon@cloudera.com>,
 Sergio Pena <sergio.pena@cloudera.com>
Cc: Peter Vary <pvary@cloudera.com>, hive <dev@hive.apache.org>,
 Aihua Xu <axu@cloudera.com>
Date: Tue, 19 Jul 2016 15:46:57 -0000
Message-ID: <20160719154657.15322.36363@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Aihua Xu <noreply@reviews.apache.org>
References: <20160719152641.15321.78416@reviews.apache.org>
In-Reply-To: <20160719152641.15321.78416@reviews.apache.org>
Reply-To: Aihua Xu <axu@cloudera.com>
archived-at: Tue, 19 Jul 2016 15:46:59 -0000

--===============9204463921881352291==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49498/#review142759
-----------------------------------------------------------


Ship it!


Ship It!

- Aihua Xu


On July 19, 2016, 3:26 p.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49498/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 3:26 p.m.)
> 
> 
> Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-14123
>     https://issues.apache.org/jira/browse/HIVE-14123
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> There are several jira issues complaining that, the Beeline does not respect hive.cli.print.current.db.
> This is partially true, since in embedded mode, it uses the hive.cli.print.current.db to change the prompt, since HIVE-10511.
> In remote mode, I think this function should use a beeline command line option instead, like for the showHeader option emphasizing, that this is a client side option.
> 
> The patch contains:
> - New configuration option
> - Changing the help text
> - Updating command hooks, to run in remote mode as well
> - Adding new hooks, for connect and go sqllite commands
> - Generalize database connection refresh command
> - Changing prompt
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml a720d08 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 66185f6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 
>   beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java c4d97bc 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 3a204c0 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 3b863ae 
>   beeline/src/main/resources/BeeLine.properties 7500df9 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java ce1f538 
>   beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java c86de0a 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java ecfeddb 
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 7ea6309 
> 
> Diff: https://reviews.apache.org/r/49498/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for the hooks, and the configuration option
> 
> Manual test in remote, and embedded mode
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


--===============9204463921881352291==--