Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58686200B3C for ; Wed, 13 Jul 2016 20:49:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 56F1C160A6A; Wed, 13 Jul 2016 18:49:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A03A1160A62 for ; Wed, 13 Jul 2016 20:49:29 +0200 (CEST) Received: (qmail 99460 invoked by uid 500); 13 Jul 2016 18:49:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 99447 invoked by uid 99); 13 Jul 2016 18:49:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2016 18:49:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 92A46270B3F; Wed, 13 Jul 2016 18:49:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1237407752657748326==" MIME-Version: 1.0 Subject: Re: Review Request 49728: HIVE-14172 LLAP: force evict blocks by size to handle memory fragmentation From: Sergey Shelukhin To: Gopal V Cc: Sergey Shelukhin , hive Date: Wed, 13 Jul 2016 18:49:26 -0000 Message-ID: <20160713184926.27833.45209@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sergey Shelukhin X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49728/ X-Sender: Sergey Shelukhin References: <20160713165428.30376.22934@reviews.apache.org> In-Reply-To: <20160713165428.30376.22934@reviews.apache.org> Reply-To: Sergey Shelukhin X-ReviewRequest-Repository: hive-git archived-at: Wed, 13 Jul 2016 18:49:30 -0000 --===============1237407752657748326== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 13, 2016, 4:54 p.m., Gopal V wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java, line 227 > > > > > > The assumption about dropping locked blocks - does it ever happen that another thread has a valid reference to that block when this is hit? LRFU policy does not need references for locked blocks because unlocking the block adds it back to the list/heap. However, this (removal) is not strictly enforced to avoid waiting/traversing when locking ie from processing thread every time. So the thread that already has to traverse removes them. It's not an eviction (eviction calls invalidate()) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49728/#review142076 ----------------------------------------------------------- On July 6, 2016, 9:31 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49728/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 9:31 p.m.) > > > Review request for hive and Gopal V. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 47325ad > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java 4def4a1 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java acbaf85 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 0838682 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 5a0b27f > llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryManager.java 6cc262e > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java 345f5b1 > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java 0846db9 > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 616c040 > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java 40edb28 > > Diff: https://reviews.apache.org/r/49728/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============1237407752657748326==--