Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D96FF200B3C for ; Wed, 13 Jul 2016 12:06:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D81D3160A6E; Wed, 13 Jul 2016 10:06:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 52089160A57 for ; Wed, 13 Jul 2016 12:06:18 +0200 (CEST) Received: (qmail 88024 invoked by uid 500); 13 Jul 2016 10:06:17 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 88010 invoked by uid 99); 13 Jul 2016 10:06:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2016 10:06:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 38B311CE0D6; Wed, 13 Jul 2016 10:06:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2418705070618742101==" MIME-Version: 1.0 Subject: Review Request 49984: HIVE-14215: Displaying inconsistent CPU usage data with MR execution engine From: Peter Vary To: Sergio Pena , Aihua Xu Cc: Peter Vary , hive Date: Wed, 13 Jul 2016 10:06:15 -0000 Message-ID: <20160713100615.8919.35710@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Peter Vary X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49984/ X-Sender: Peter Vary Reply-To: Peter Vary X-ReviewRequest-Repository: hive-git archived-at: Wed, 13 Jul 2016 10:06:19 -0000 --===============2418705070618742101== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49984/ ----------------------------------------------------------- Review request for hive, Aihua Xu and Sergio Pena. Bugs: HIVE-14215 https://issues.apache.org/jira/browse/HIVE-14215 Repository: hive-git Description ------- Reordered the time caluclation, so the displayed data is consistent now Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java cfb4a28 Diff: https://reviews.apache.org/r/49984/diff/ Testing ------- Manually. Should have to put sleep at the end of the while cycle, to consistently reproduce the problem. Keeping the same sleep there, the displayed data is consistent with the patch. Sleep removed from the code in the end :) If you have any idea, how to produce a reliable test case for this, I am open for every suggestions. Thanks, Peter Thanks, Peter Vary --===============2418705070618742101==--