hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 50401: Make the print of COLUMN_STATS_ACCURATE more stable.
Date Mon, 25 Jul 2016 18:29:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50401/#review143407
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 108)
<https://reviews.apache.org/r/50401/#comment209186>

    nit: Hive standard limits lines to 100 characters... all these comments need not be reformatted.
Can you update your editor preferences? ;)



common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 203)
<https://reviews.apache.org/r/50401/#comment209187>

    should this be "columns.get..."?



common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 264)
<https://reviews.apache.org/r/50401/#comment209188>

    why trace and not at least info?


- Sergey Shelukhin


On July 25, 2016, 6:14 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50401/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 6:14 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14317
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 01e6010 
> 
> Diff: https://reviews.apache.org/r/50401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message