hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <>
Subject Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt
Date Tue, 19 Jul 2016 15:26:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 19, 2016, 3:26 p.m.)

Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar.


Some minor changes, and addressing the review

Bugs: HIVE-14123

Repository: hive-git


There are several jira issues complaining that, the Beeline does not respect hive.cli.print.current.db.
This is partially true, since in embedded mode, it uses the hive.cli.print.current.db to change
the prompt, since HIVE-10511.
In remote mode, I think this function should use a beeline command line option instead, like
for the showHeader option emphasizing, that this is a client side option.

The patch contains:
- New configuration option
- Changing the help text
- Updating command hooks, to run in remote mode as well
- Adding new hooks, for connect and go sqllite commands
- Generalize database connection refresh command
- Changing prompt

Diffs (updated)

  beeline/pom.xml a720d08 
  beeline/src/java/org/apache/hive/beeline/ 66185f6 
  beeline/src/java/org/apache/hive/beeline/ 5aaa385 
  beeline/src/java/org/apache/hive/beeline/ c4d97bc 
  beeline/src/java/org/apache/hive/beeline/ 3a204c0 
  beeline/src/java/org/apache/hive/beeline/ 3b863ae 
  beeline/src/main/resources/ 7500df9 
  beeline/src/test/org/apache/hive/beeline/ ce1f538 
  beeline/src/test/org/apache/hive/beeline/ c86de0a 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/ ecfeddb

  jdbc/src/java/org/apache/hive/jdbc/ 7ea6309 



Unit tests for the hooks, and the configuration option

Manual test in remote, and embedded mode


Peter Vary

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message