hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 50054: CTAS with UNION ALL puts the wrong stats + count(*) = 0 in Tez
Date Fri, 15 Jul 2016 18:45:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50054/#review142425
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
<https://reviews.apache.org/r/50054/#comment207986>

    Is this change necessary? 
    It seems setting configuration for stats task is better done in addStatsTask()?



ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java (line 308)
<https://reviews.apache.org/r/50054/#comment207987>

    I guess you want linked.size() here.


- Ashutosh Chauhan


On July 14, 2016, 11:18 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50054/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 11:18 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14236
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 73fcb03 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 812a943 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java c626add 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java f555741 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 32bf24d 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 07ed4fd 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsCollectionContext.java ae6f2ac 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsPublisher.java 3a49b30 
>   ql/src/test/queries/clientpositive/union_stats.q PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/union_stats.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/union_stats.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50054/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message