hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vihang Karajgaonkar <vih...@cloudera.com>
Subject Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths
Date Thu, 14 Jul 2016 21:57:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49919/#review142292
-----------------------------------------------------------




beeline/src/java/org/apache/hive/beeline/BufferedRows.java (line 76)
<https://reviews.apache.org/r/49919/#comment207860>

    Thanks for reviewing. I thought of adding it in the above loop like you mentioned, but
then went against that for readability reasons since max.length should not be too big (it
is numbers of columns in a row). I will add it now in the loop.
    
    btw, If we have to add it in the loop it should be 
    Math.min(Math.max(max[j], row.sizes[j] + 1), maxColumnWidth); Did you mean the same?


- Vihang Karajgaonkar


On July 12, 2016, 5:51 p.m., Vihang Karajgaonkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49919/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 5:51 p.m.)
> 
> 
> Review request for hive, Mohit Sabharwal, Sergio Pena, Sahil Takiar, and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14135 : beeline output not formatted correctly for large column widths
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml a720d0835314221ec3bd9e8d354d148498ff794c 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa38527734d46de037352ff51e54e0ae1cede0

>   beeline/src/java/org/apache/hive/beeline/BufferedRows.java 962c5319bb7e6e448979e1cef80a086cadd2ecc6

>   beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49919/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message