hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gopal V <go...@hortonworks.com>
Subject Re: Review Request 49728: HIVE-14172 LLAP: force evict blocks by size to handle memory fragmentation
Date Wed, 13 Jul 2016 16:54:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49728/#review142076
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java (line
226)
<https://reviews.apache.org/r/49728/#comment207571>

    The assumption about dropping locked blocks - does it ever happen that another thread
has a valid reference to that block when this is hit?



llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java (line
228)
<https://reviews.apache.org/r/49728/#comment207572>

    Race condition?


- Gopal V


On July 6, 2016, 9:31 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49728/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 9:31 p.m.)
> 
> 
> Review request for hive and Gopal V.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 47325ad

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
4def4a1 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java acbaf85

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java
0838682 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
5a0b27f 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryManager.java 6cc262e 
>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java 345f5b1

>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java 0846db9

>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java
616c040 
>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java 40edb28

> 
> Diff: https://reviews.apache.org/r/49728/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message