hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sahil Takiar <>
Subject Re: Review Request 49782: HIVE-14170: Beeline IncrementalRows should buffer rows and incrementally re-calculate width if TableOutputFormat is used
Date Fri, 08 Jul 2016 20:00:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 8, 2016, 8 p.m.)

Review request for hive, Sergio Pena, Thejas Nair, and Vaibhav Gumashta.

Bugs: HIVE-14170

Repository: hive-git


* Added a new BeeLine Options called `incrementalBufferRows` which controls the number of
`Row`s the `IncrementalRows` class should buffer, by default it is 1000
* Modified `BufferedRows` so that it can accept a limit on the number of `Row`s it buffers
* Modified `IncrementalRows` to read the value of `incrementalBufferRows` and buffer rows
as per HIVE-14170
* The class delegates all buffering work to a `BufferedRows` class
* This has the advantage that all the width calculaltion that spans multiple rows can be encapsulate
in the `BufferedRows` class, there is no need to re-implement the logic in `IncrementalRows`
* `IncrementalRows` will buffer `incrementalBufferRows` rows at a time, when the buffer is
depleted, it will fetch the next buffer and re-calculate the width for that buffer


  beeline/pom.xml a720d08 
  beeline/src/java/org/apache/hive/beeline/ 5aaa385 
  beeline/src/java/org/apache/hive/beeline/ 962c531 
  beeline/src/java/org/apache/hive/beeline/ 8aef976 
  beeline/src/java/org/apache/hive/beeline/ 453f685 
  beeline/src/test/org/apache/hive/beeline/ PRE-CREATION 



* Unit Test added for `IncrementalRows`
* Tested locally


Sahil Takiar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message