hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Takuma Wakamori <wakamori.tak...@gmail.com>
Subject Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.
Date Mon, 20 Jun 2016 09:32:24 GMT


> On 6月 15, 2016, 8:09 a.m., Sergey Shelukhin wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java, line 265
> > <https://reviews.apache.org/r/48656/diff/1/?file=1417173#file1417173line265>
> >
> >     between should have a fixed number of arguments (3 IIRC), not a variable list

Updated to use fixed number of arguments.


- Takuma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48656/#review137610
-----------------------------------------------------------


On 6月 20, 2016, 6:31 p.m., Takuma Wakamori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48656/
> -----------------------------------------------------------
> 
> (Updated 6月 20, 2016, 6:31 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13958: Support prohibiting string to decimal auto-casts.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1e0ffa48f343ee11d78ae3a1de9f05ef4fee8eb0

>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java aef46da4564808fd2c17fdd0a1cab442366587a3

>   ql/src/test/queries/clientnegative/compare_double_bigint.q 8ee4b277cbf729e6134e8f10dc6c76d1e4cd3482

>   ql/src/test/queries/clientnegative/compare_double_bigint_between.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint.q 810f65d4d2b448b99cdb8907c016e36b1d9e276e

>   ql/src/test/queries/clientnegative/compare_string_bigint_between.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_double_bigint_between.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/compare_double_bigint_in.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint_between.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/compare_string_bigint_in.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Takuma Wakamori
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message