hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 48500: HIVE-13982
Date Wed, 15 Jun 2016 15:23:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48500/#review137744
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java (line
247)
<https://reviews.apache.org/r/48500/#comment202947>

    Can you add a comment that why we don't care for sql type?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (line
308)
<https://reviews.apache.org/r/48500/#comment202948>

    Can you add a comment when this else block will be executed?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (line
352)
<https://reviews.apache.org/r/48500/#comment202949>

    We get here if RS-*-RS and there is a single parent for 2nd RS. What if there is a PTF
operator in between. Will merging be triggered in that case? If so, will it be valid?



ql/src/test/results/clientpositive/vector_groupby_reduce.q.out (line 788)
<https://reviews.apache.org/r/48500/#comment202950>

    Plan change expected?


- Ashutosh Chauhan


On June 13, 2016, 12:06 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48500/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 12:06 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-13982
>     https://issues.apache.org/jira/browse/HIVE-13982
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13982
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
353d8db41af10512c94c0700a9bb06a07d660190 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
77771c3eb8155defa99a223ccf4ee4b072abb40a 
>   ql/src/test/queries/clientpositive/limit_pushdown2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/bucket_groupby.q.out e198617c82b8ab4c3ad3d8b255975413fbdc382d

>   ql/src/test/results/clientpositive/limit_pushdown2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/lineage3.q.out 12ae13e388b3cb9c051cb419b75682fa4296d211

>   ql/src/test/results/clientpositive/perf/query45.q.out 04f9b02b019b6cf591dee48964a73fdb4a4b285f

>   ql/src/test/results/clientpositive/spark/vectorization_14.q.out cb3d9a4da84a379e00550ce7e31893b304d5e560

>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out 1871c7e443cf775b09badc4cbf4b86e23ad9e525

>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out 553066039881f225634c08d93a9054df5636e5d2

>   ql/src/test/results/clientpositive/tez/vector_groupby_reduce.q.out 7f00b064e5a91b45282823e2725e11ab7f508b01

>   ql/src/test/results/clientpositive/tez/vectorization_14.q.out 2a598332207f4540defa21a107642aa0502e1a58

>   ql/src/test/results/clientpositive/vector_groupby_reduce.q.out bc23b365b02b505d0f8e79cdacca3449bf46ead3

>   ql/src/test/results/clientpositive/vectorization_14.q.out 6d4f13a23de5c184cd100af07ac19f24ba9fac4a

> 
> Diff: https://reviews.apache.org/r/48500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message