hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.
Date Tue, 14 Jun 2016 23:09:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48656/#review137610
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java (line 248)
<https://reviews.apache.org/r/48656/#comment202804>

    between should have a fixed number of arguments (3 IIRC), not a variable list


- Sergey Shelukhin


On June 13, 2016, 5:59 p.m., Takuma Wakamori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48656/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 5:59 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13958: Support prohibiting string to decimal auto-casts.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java aef46da4564808fd2c17fdd0a1cab442366587a3

>   ql/src/test/queries/clientnegative/compare_double_bigint_between.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint.q 810f65d4d2b448b99cdb8907c016e36b1d9e276e

>   ql/src/test/queries/clientnegative/compare_string_bigint_between.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_double_bigint_between.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/compare_double_bigint_in.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint3.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint_between.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/compare_string_bigint_in.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Takuma Wakamori
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message