hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vaibhav Gumashta <vgumas...@hortonworks.com>
Subject Re: Review Request 48386: HIVE-13723 patch to fix Float cast to Double bug when using Thrift Serde
Date Wed, 08 Jun 2016 22:46:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48386/#review136724
-----------------------------------------------------------


Ship it!




Ship It!

- Vaibhav Gumashta


On June 8, 2016, 12:50 a.m., ziyang zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48386/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 12:50 a.m.)
> 
> 
> Review request for hive, Thejas Nair and Vaibhav Gumashta.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> In this patch, instead of set the type of float ColumnBuffer as TYPE_DOUBLE, I set it
as TYPE_FLOAT, but let it go through the same process as double ColumnBuffer.
> 
> 
> Diffs
> -----
> 
>   serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java 929c405 
> 
> Diff: https://reviews.apache.org/r/48386/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> ziyang zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message