hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Siddharth Seth <ss...@apache.org>
Subject Re: Review Request 48186: HIVE-13443 LLAP: signing for the second state of submit (the event)
Date Fri, 03 Jun 2016 19:10:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48186/#review136090
-----------------------------------------------------------



Mostly looks good. At the moment there's only a single event. With SMB joins etc - there can
be multiple events, in which case this falls over; I don't think we ever run into that case
though, so this is OK.
Most of the comments are around the comments added in the patch.


llap-common/src/protobuf/LlapDaemonProtocol.proto (line 107)
<https://reviews.apache.org/r/48186/#comment201097>

    This part of the comment isn't necessarily correct.
    Some form of events are likely to persist.
    
    The commentary is nice. All of this is using @private tez structures.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java (line 39)
<https://reviews.apache.org/r/48186/#comment201100>

    Nit: Unused import.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java (line 295)
<https://reviews.apache.org/r/48186/#comment201078>

    Don't think that's required, given that the entire event is being signed.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java (line 359)
<https://reviews.apache.org/r/48186/#comment201088>

    Don't think this message is correct. There's nothing inside splitBytes other than the
split (which unfortunately has a really large Hive configuration)



ql/src/java/org/apache/tez/dag/api/TaskSpecBuilder.java (line 66)
<https://reviews.apache.org/r/48186/#comment201101>

    Please elaborate ? (This is not a public Tez API).
    
    Should this function just be removed. Used only once - the usage can be replaced by vertex.getInputs


- Siddharth Seth


On June 2, 2016, 8:55 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48186/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 8:55 p.m.)
> 
> 
> Review request for hive and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-client/src/java/org/apache/hadoop/hive/llap/LlapInputSplit.java 02aedfd 
>   llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java
0edb1cd 
>   llap-common/src/java/org/apache/hadoop/hive/llap/NotTezEventHelper.java PRE-CREATION

>   llap-common/src/protobuf/LlapDaemonProtocol.proto 486ba0a 
>   llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 4306c22

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
d439c07 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTaskReporter.java
dc4482e 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java
0d9882b 
>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
96d626a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java 54fc3af 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java 140dbda

>   ql/src/java/org/apache/tez/dag/api/TaskSpecBuilder.java 6d31802 
> 
> Diff: https://reviews.apache.org/r/48186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message