hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 48159: HIVE-13901: Hivemetastore add partitions can be slow depending on filesystems
Date Fri, 03 Jun 2016 00:42:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48159/#review136018
-----------------------------------------------------------




metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 269)
<https://reviews.apache.org/r/48159/#comment201017>

    nit: private



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2347)
<https://reviews.apache.org/r/48159/#comment201018>

    is there the expectation that results are in the same order as request? should be relatively
easy to achieve.



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2353)
<https://reviews.apache.org/r/48159/#comment201019>

    terminate other tasks if possible?



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2354)
<https://reviews.apache.org/r/48159/#comment201020>

    cleanup code needs to be updated below. As far as I can tell, when this throws there can
be completed operations yet to be added to the set, unless they are decisively terminated
or allowed to finish



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2518)
<https://reviews.apache.org/r/48159/#comment201021>

    same concerns as above


- Sergey Shelukhin


On June 3, 2016, 12:33 a.m., Rajesh Balamohan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48159/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 12:33 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-13901
>     https://issues.apache.org/jira/browse/HIVE-13901
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Depending on FS, creating external tables & adding partitions can be expensive (e.g
msck which adds all partitions).
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ff5c858 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 94dd72e 
> 
> Diff: https://reviews.apache.org/r/48159/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajesh Balamohan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message