Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DD6D42009A0 for ; Sat, 21 May 2016 21:50:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D20F4160A04; Sat, 21 May 2016 19:50:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 59022160A02 for ; Sat, 21 May 2016 21:50:51 +0200 (CEST) Received: (qmail 78945 invoked by uid 500); 21 May 2016 19:50:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 78928 invoked by uid 99); 21 May 2016 19:50:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 May 2016 19:50:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6DB6A1C001F; Sat, 21 May 2016 19:50:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8174713327200428546==" MIME-Version: 1.0 Subject: Re: Review Request 46690: HIVE-13068 From: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= To: Ashutosh Chauhan Cc: hive , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Date: Sat, 21 May 2016 19:50:49 -0000 Message-ID: <20160521195049.19666.93247@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cnoreply=40reviews=2E?=@reviews.apache.org, =?utf-8?q?apache=2Eorg=3E?=@reviews.apache.org X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46690/ X-Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cnoreply=40reviews?= =?utf-8?b?LmFwYWNoZS5vcmc+?= References: <20160521164117.19634.61330@reviews.apache.org> In-Reply-To: <20160521164117.19634.61330@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregatePullUpConstantsRule.java X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectFilterPullUpConstantsRule.java Reply-To: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cjcamachorodriguez?=@reviews.apache.org, =?utf-8?q?=40hortonworks=2Ecom=3E?=@reviews.apache.org X-ReviewRequest-Repository: hive-git archived-at: Sat, 21 May 2016 19:50:53 -0000 --===============8174713327200428546== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java, line 113 > > > > > > This is weird. Why does backtrack() needs to worry about whether cbo succeeded or not? I just added it because if CBO did not succeed, it is taken care of by other optimization rules. But it is true it is weird to make it dependent on that. I will always fold in this case. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 3147 > > > > > > Why does this function care if cbo was executed? We only fold when we go back from Calcite through the AST, not when we go into Calcite; if we were folding when we go into Calcite, this was leading to some Exceptions, as the Calcite planner has some assumptions around what it expects from the SemanticAnalyzer. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/cbo_rp_join1.q.out, line 144 > > > > > > No need for additional filter. Follow-up? This is a good catch, thanks. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog_semijoin.q.out, lines 440-443 > > > > > > Simplification of this expression is false, no? The whole expression should be simplified to false, idd. We do not catch it because of how the first expression is written. This is not a regression, but I can create a follow-up to tackle this. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog_semijoin.q.out, line 607 > > > > > > Looks incorrect. This should be false (which was the case earlier). Previous value for the column was '(id = 100)'. That is why we infer true, as '(id = 100)=true'. This is correct, if the predicate below would be true, the column should have that value. But it will never be true idd. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog_semijoin.q.out, line 692 > > > > > > Follow-up? Yes, I will need to check that one further, it is weird. I am thinking that probably the left semijoin is introduced by the SemanticAnalyzer, and that is why the constants are not propagated. I will create a new JIRA case for this. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/index_auto_unused.q.out, lines 359-360 > > > > > > SimpleFetchOptimizer got tripped? Follow-up? Mm, true. This is one of the tests that gave me more trouble. I will work on it in follow-up. We already have HIVE-13811 for it, I updated its description. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/infer_join_preds.q.out, line 161 > > > > > > Follow-up? Yes, this is HIVE-13803. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/infer_join_preds.q.out, line 252 > > > > > > Lost a very useful predicate? Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out, line 2342 > > > > > > Lost DPP? Can you check if test was specifically written for DPP. If so, we can modify test and/or configs so it still test DPP Yes, it does not do DPP because static partition pruning kicked in. The query is: EXPLAIN select count(*) from srcpart join (select ds as ds, ds as `date` from srcpart group by ds) s on (srcpart.ds = s.ds) where s.`date` = '2008-04-08'; For any similar query, the predicate will be inferred and static partition pruning will kick in now. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out, lines 4987-4989 > > > > > > Any idea why plan changed? Seems like a better plan. As above, static partition pruning kicked in. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out, lines 2100-2103 > > > > > > Lost DPP. Need to modify test/configs? As above. It's really cool we are inferring further predicates and static partition pruning is kicking in now. Question remain how to test the original cases... but I would say it is fine to keep it this way. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out, lines 4622-4624 > > > > > > Plan change expected? Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out, lines 4744-4748 > > > > > > DPP lost. Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out, lines 2236-2240 > > > > > > Lost DPP. Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out, lines 4887-4891 > > > > > > Lost DPP. Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out, line 2037 > > > > > > DPP lost. Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out, line 4612 > > > > > > DPP lost. Same as above. > On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out, line 1830 > > > > > > Is this correct? count(val) != count(1) _val_ is a grouping value, thus it is a constant for each resulting tuple. Thus it is the same as count(1). - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/#review134227 ----------------------------------------------------------- On May 20, 2016, 9:53 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46690/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 9:53 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13068 > https://issues.apache.org/jira/browse/HIVE-13068 > > > Repository: hive-git > > > Description > ------- > > HIVE-13068 > > > Diffs > ----- > > hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out 27446b41db80ee98d56a4101a87f76be7f6dea2f > hbase-handler/src/test/results/positive/hbase_queries.q.out a99f561828fb8466a70ad639e73aaf65ac199b72 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcCtx.java bc52f7b8d7a151859631dba3ff585788f8c19698 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/FixedBucketPruningOptimizer.java 9e9beb0d73372c81cc73afb2b92b1a791e3a491e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 37dbe32008685ba22e5dae1e4bfbfe090c5bfe9f > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java bf9a0a367b3b85f039076ac78290f8e35a8c3c62 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java 4adf7b2b16eb2cea68e0fe9b554a62e65b4c388d > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 0cfd5298899ea8dd16c073b26546c40de4451271 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java c6d1d46c62d8550750eea092245a55dd3b327f66 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 2f309f3de6acfac09b7b0d84cbb9d4275e317aeb > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregatePullUpConstantsRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectFilterPullUpConstantsRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java 2fe9b75038de8261fa123aa6e1d318ea6b0d1cec > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortLimitPullUpConstantsRule.java 3be9b0a0dafde81692db696f1a8f9099a132aec6 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveUnionPullUpConstantsRule.java 2552f8747ba4b3d4f46d1d06a5fe381cbd039468 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java e8107471eaebaf95aeb32fa93b2917861ebb0795 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java de7e2f8feae424a27075b17ad9fb7de2dd81e735 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java e51b6c49f447d04fdcac6d23deda5d980f43822d > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java 7fbf8cd232d8bb1114d64befd559646001dbd032 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 13078089bd7d7552fdd5d0c28ab7534c9dc5220b > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java 368264c1de1b406a76dd9e12848c0f8a94b0df54 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java ee4f4ead6066a29e867cf51582c45d3dc69b1880 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 0b76bffb42d88204f486278a12bbf24d1b7fc274 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java 2825f7787de4d42e9532bfb2642f4f95ba8f8b83 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java 991117945e8bce1c4098f0641ff7674c8a314147 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java de6a053a5b299ee39ec9af865d077a886497189f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7162c089cd125c660abaad5838da28ab167c73b5 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 2eaed564304f0f8293ce35227fcfef15398305ef > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java c6f89074457e1ed4e61d52c01d9cc515fe1a6f09 > ql/src/test/queries/clientpositive/join_view.q 16b6816f0c8618691ba7a28f4ca467d7526d6e13 > ql/src/test/results/clientpositive/annotate_stats_filter.q.out ba0419e461a5b5649bd7d4c67602b8cb747961ea > ql/src/test/results/clientpositive/archive_excludeHadoop20.q.out c2b98727d21f4990ae7496a0a8fa9ac16598f4c0 > ql/src/test/results/clientpositive/archive_multi.q.out 0ad29d122153bd4adf4d19064188b0c4f94e05ab > ql/src/test/results/clientpositive/authorization_explain.q.java1.7.out a9ed0495fcecadbddf1fcfb764e916fbb5406662 > ql/src/test/results/clientpositive/auto_join33.q.out b0b3019d5c7a6ff6058b5bfd7c965257f8850367 > ql/src/test/results/clientpositive/auto_join8.q.out 324f95d550add0ead3215bbdd0933ddd6456f9c9 > ql/src/test/results/clientpositive/auto_join_filters.q.out 2fdf470036e0df898ad2986f3a26628e6e6bba44 > ql/src/test/results/clientpositive/auto_join_nulls.q.out 4af5535f4a0a9c07aca7342a0a31ddb9c9b2790f > ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out d8eacbeec54db58ddd2c6b194d6f012ad19a3bbc > ql/src/test/results/clientpositive/bucket_groupby.q.out ae736f98a19d4fa9a04fb9ba2f8fbe8c468d468a > ql/src/test/results/clientpositive/cast1.q.out 48a0c14031ef38dd5b4df7efa718a4d6ce04bc94 > ql/src/test/results/clientpositive/cbo_const.q.out c2a51943d46eff67fa32f9fbae61ee484b507510 > ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out a1be9b9d69062a707a7c28ac445f377da3b0b33b > ql/src/test/results/clientpositive/cbo_rp_join1.q.out f3982b8866d44dd0b4c01bf1f75e44c861f85756 > ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 2d3f12bc1f60740330ecbef67183bcb6cabd3bcb > ql/src/test/results/clientpositive/colstats_all_nulls.q.out d567ec8f9166049ea87bad2a44ec7cc0c5ec5b96 > ql/src/test/results/clientpositive/constantPropagateForSubQuery.q.out c7a39f555d752f51f4d6dd613f4bc3e3ace40ae3 > ql/src/test/results/clientpositive/constant_prop_3.q.out 36359135512d30a7370ed45ecd8ae2cbffae3e34 > ql/src/test/results/clientpositive/constprog3.q.out e01a733bf199242ecc5810470ba3133a14f89b8f > ql/src/test/results/clientpositive/constprog_semijoin.q.out 35d062d7a534c9cf9705fda44eaf81fa97e92229 > ql/src/test/results/clientpositive/cp_sel.q.out f42ec84dc6f147278da93c33375500a48bb0e008 > ql/src/test/results/clientpositive/create_genericudf.q.out db3a9b5a9098573f07715f0192718307db7f6590 > ql/src/test/results/clientpositive/create_view.q.out e23a9933086bf78c94262a1cb25090be9fa857d1 > ql/src/test/results/clientpositive/cross_join.q.out f01993db8a2d96c4fdd55df1b94590341a6000e8 > ql/src/test/results/clientpositive/cross_join_merge.q.out f15dd174e4677613cf55be96af37e1a127052d0a > ql/src/test/results/clientpositive/cross_product_check_1.q.out 4feb798e80266abf937b3d476008e6126da1b4f7 > ql/src/test/results/clientpositive/cross_product_check_2.q.out f34f2b5663ee561718e3a8c74439a3a28105454f > ql/src/test/results/clientpositive/cte_5.q.out 96a65438f0fe0f5189e0a257c4fd71290bdb0804 > ql/src/test/results/clientpositive/cte_mat_1.q.out b7d5f7d1f6cde1990c56803fc8e7c566dacd1ba8 > ql/src/test/results/clientpositive/cte_mat_2.q.out b7d5f7d1f6cde1990c56803fc8e7c566dacd1ba8 > ql/src/test/results/clientpositive/decimal_stats.q.out 0ea9ed656fd215596f4f746c016aa25bb1cfa93c > ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 9a09c4c205f18a1033742bc61c7d624dcf81c0b8 > ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 391acff166486881187f6afb902e731e947129b9 > ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 3b24a2e3fb85b1bb2ccfb1456ce00c4e3962eec7 > ql/src/test/results/clientpositive/explain_logical.q.out 5b8a422a19bc47ebe7c0daf47b819235c58c8eb8 > ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 132b590230d2fba13d77a004b5bb5041999fc497 > ql/src/test/results/clientpositive/fold_case.q.out 53139da206481bb04db865819c30ec3775452449 > ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 106ad6b836b6c2dbf43e236c488621ef21bae47b > ql/src/test/results/clientpositive/fold_when.q.out 5b684089c0bdfd9be3e05241ac5af22c1f16eca3 > ql/src/test/results/clientpositive/folder_predicate.q.out 7fcc1722d87a9e2734b3467fe1a5f320af0a422c > ql/src/test/results/clientpositive/groupby_ppd.q.out 515f62eeb37a37fcdaf9e0e6c6c3a17108228549 > ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7ef56fcb4088f00a0f7e5a11c72f5a8671802194 > ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 28194874dd9ddae539ec455de80df68d2aafdabf > ql/src/test/results/clientpositive/index_auto_unused.q.out 81079f864580bde124be4d0e6af03f46505a4348 > ql/src/test/results/clientpositive/index_stale_partitioned.q.out f2aa0e4e86639b90476dbbf420b78837667877bb > ql/src/test/results/clientpositive/infer_join_preds.q.out 8afc9058041c603c78782283500403e26c933713 > ql/src/test/results/clientpositive/input23.q.out dcb2891e0ca3c48d8bbcc51af5cff7ad5c3f4a6a > ql/src/test/results/clientpositive/input26.q.out 87b7081cdfdee1b52eba24e996ee020290ba3a20 > ql/src/test/results/clientpositive/input6.q.out 5ed27671e21e22c6358aa73bc4a62a973ac5e9a8 > ql/src/test/results/clientpositive/input8.q.out 03857fca9896c4de3a32585c60fd5c694b2724c6 > ql/src/test/results/clientpositive/input_part10.q.out c8fb37e4c0bb722a0314642673733510d51b57a5 > ql/src/test/results/clientpositive/insert_into5.q.out b9510b976adbd720d97d2ddbc709df39aedd6699 > ql/src/test/results/clientpositive/insert_nonacid_from_acid.q.out f7a98538b555cc7e62b70595dddf607076182268 > ql/src/test/results/clientpositive/join38.q.out 7f76c5dd9bf30690b58c9fb972e27feb2ed1b644 > ql/src/test/results/clientpositive/join42.q.out 462e49e70ebb07c177322e3eb20179766b779b2e > ql/src/test/results/clientpositive/join8.q.out d7e7cb1754994ffe983caf3e70525e58131d1c80 > ql/src/test/results/clientpositive/join_alt_syntax.q.out 339e004e6c4c7dba54573b297e8e5d5a846c43be > ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out b4f1eb3d81fc3d71e5850b39d2af2759113c4aad > ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out 3975b4f7bc947fa1fdd20c68ef06bf2991b6c401 > ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 82d1b82f181c99a70ce9865c818e89b13f3ab7f4 > ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 297154fd77d034f3a5ed88783f68502ebc2c9a22 > ql/src/test/results/clientpositive/join_filters.q.out 79e8b07240bd84978855771578ad75866e2fd9af > ql/src/test/results/clientpositive/join_nulls.q.out b536985016bc0f480fda5bacf0a3c15b0f4b1ea5 > ql/src/test/results/clientpositive/join_reorder.q.out ba3c8d4b991303d20515f8caff4ed035f63ec434 > ql/src/test/results/clientpositive/join_view.q.out 57043fbf96c15e37e7b8f2fb2083c043d42edc4d > ql/src/test/results/clientpositive/lineage2.q.out a08094ad180ed5bf0621b11a19294e3e2257d255 > ql/src/test/results/clientpositive/lineage3.q.out 61acf52e8e7ea4cf61fcd74742255aec54c09ff4 > ql/src/test/results/clientpositive/list_bucket_query_oneskew_1.q.out 6a9b4a18d462948fd575dc744694ed7fd0b7527a > ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 8517a5247f60b18577f57bf19ae8f6e198ec93c7 > ql/src/test/results/clientpositive/llap/cte_mat_1.q.out 9ba574db3ad9facff58e67bd328ee0ad5865dc5c > ql/src/test/results/clientpositive/llap/cte_mat_2.q.out 9ba574db3ad9facff58e67bd328ee0ad5865dc5c > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out 9f0771818ee98fe3c75a9dfbdf13e3f53b2b0c71 > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning_2.q.out 8ed8ab44f1a978c662296335ee23d0e8a2fb39d0 > ql/src/test/results/clientpositive/llap/hybridgrace_hashjoin_1.q.out c750dc255a6549bcba1ae3d66b2042b963047cba > ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_1.q.out 98ba8dd2a8b7798b9e16a4a467a9fe646770883c > ql/src/test/results/clientpositive/llap/tez_self_join.q.out 68f231c7e0fb37667d0bbcbfcf8db81c9a7e775f > ql/src/test/results/clientpositive/llap/tez_union_dynamic_partition.q.out 14a273b8d6f2ad01b9f31a8aca724930d0d5af30 > ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_1.q.out 17d5992e65fcc1c96cd0c385d410ba7a82bb0a48 > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 94754875d6414d7cb76d0a86297bd3f4d81289ef > ql/src/test/results/clientpositive/masking_2.q.out f998cbd353a428d40afacc948475501717c5f506 > ql/src/test/results/clientpositive/mergejoin.q.out a85fd8b25bdccfd723cb0392c93992bd3151849c > ql/src/test/results/clientpositive/nonblock_op_deduplicate.q.out ea2541685ddb2d4f165c8fe38145173c17a58ce1 > ql/src/test/results/clientpositive/orc_llap.q.out bae69bb7d816758cc6f8763600c89f766f114190 > ql/src/test/results/clientpositive/partition_multilevels.q.out 948d3a0db52d427e91c87079f012bcef0d9edf21 > ql/src/test/results/clientpositive/pcr.q.out 7222617f762d6d0223026f1d9963b0270851d931 > ql/src/test/results/clientpositive/perf/query18.q.out a1c9da573d5a79582243116462c04eb9e898105f > ql/src/test/results/clientpositive/perf/query26.q.out 98a85f741c2381d449fea2169cf9d7b687b2f000 > ql/src/test/results/clientpositive/perf/query27.q.out 36302ca9601210df0d5b5c55c00c09777c9bf101 > ql/src/test/results/clientpositive/perf/query28.q.out 01579282a006a0f1599f36f1c8182c040e220373 > ql/src/test/results/clientpositive/perf/query31.q.out 9d0a90480f0dd4d2cb0e3819fa35ea8928d96534 > ql/src/test/results/clientpositive/perf/query39.q.out 04129c103eb85ea5d28a11c5cff6884f676d3938 > ql/src/test/results/clientpositive/perf/query42.q.out c6c4a3c98fae941e0caa1a9ac5401fa778ea1212 > ql/src/test/results/clientpositive/perf/query48.q.out 0964564c03738c122cece89fa69395c5a16b2862 > ql/src/test/results/clientpositive/perf/query52.q.out 21f3a39ff98a5e51f472db83913a092cb4f5e7dd > ql/src/test/results/clientpositive/perf/query64.q.out 3654f428ac96d979be0ec8dedffeb762dad7c129 > ql/src/test/results/clientpositive/perf/query66.q.out b19cc77869bd953faeba74ecbaa4cb55edc2bc45 > ql/src/test/results/clientpositive/perf/query7.q.out 749b3615ab1a8e6666efb3be9f1f6bf1df7cd1fb > ql/src/test/results/clientpositive/perf/query72.q.out 8bf783849340cc093dcf8b20db1eeb9fd73785ab > ql/src/test/results/clientpositive/perf/query75.q.out e44a48e3ad072c6f20f7ebae44e295f0095199e3 > ql/src/test/results/clientpositive/perf/query88.q.out e3f69d3b4739ebfb692c3b8a5aa343b539bb0906 > ql/src/test/results/clientpositive/perf/query90.q.out eea2a067d319b2ea56488527f600433a4d64f55f > ql/src/test/results/clientpositive/pointlookup2.q.out d0ad68a83599efd3821fa8f238d1dc3655d13c42 > ql/src/test/results/clientpositive/pointlookup3.q.out 39804cf5fce76f9c333f16c63f60cf75f62d742b > ql/src/test/results/clientpositive/ppd_constant_expr.q.out 17e2bab37c009ee1113d7d56700c3fa7b50004bd > ql/src/test/results/clientpositive/ppd_join5.q.out f464c1705299863850cc4eae2659cfcaf48bae5e > ql/src/test/results/clientpositive/ppd_outer_join4.q.out ba5d18700d0e0e392ae3e7cb97648b253fcbf68f > ql/src/test/results/clientpositive/ppd_outer_join5.q.out 65ca9d1c36ca385c436aa40f0ca0cb77e5048404 > ql/src/test/results/clientpositive/ppd_repeated_alias.q.out 3dbd25819803957b8d66a956f833587d6d41b0f2 > ql/src/test/results/clientpositive/ppd_udf_case.q.out 1c1c2a4f5507df31d87bc5a06824b1a6d62bf3cb > ql/src/test/results/clientpositive/ppd_union_view.q.out 435b6f92aa866a27e3c50d852837bab064508dcc > ql/src/test/results/clientpositive/quotedid_basic.q.out 76bd8831c923aa6d5f2e2a10f58da28314f65eb5 > ql/src/test/results/clientpositive/quotedid_partition.q.out 66cff2a781e591cd75d5d01326265e5f41a83e8f > ql/src/test/results/clientpositive/rand_partitionpruner3.q.out a2a06b2a53bd8ce413b182cf8fdd9bfee21e4343 > ql/src/test/results/clientpositive/recursive_dir.q.out 599b255e74ad1579a971af083bf986ae636aa9fa > ql/src/test/results/clientpositive/semijoin4.q.out 015dad1d682ab6e5bcb228849ca5b772f1b461f1 > ql/src/test/results/clientpositive/semijoin5.q.out 70d705ae6291c847ae4543ef7d59183afe1235bd > ql/src/test/results/clientpositive/skewjoin.q.out bd954efb0ab64a068e2a536b2f9dca45136f11b4 > ql/src/test/results/clientpositive/smb_mapjoin_25.q.out b0db59e03884d73b57737201bd03bd818a00b065 > ql/src/test/results/clientpositive/spark/auto_join8.q.out a769f4cea841c8524e37c1dab0a00a53c92f0d7c > ql/src/test/results/clientpositive/spark/auto_join_filters.q.out 84810d54aa59328b81dcc4435bf6aaaca3e02608 > ql/src/test/results/clientpositive/spark/auto_join_nulls.q.out 15f4791a5a91955077abe37dd33ed2e8e34c33fa > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out eff367139ad9bc0ca5c21e9b8b3ab201ba63ad4d > ql/src/test/results/clientpositive/spark/bucketizedhiveinputformat.q.out f164f9dc8acaa26fa7c230bb0d08c7d46ef3cbc6 > ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 85387a74595f4253b2b89c2b13245c7a4333983c > ql/src/test/results/clientpositive/spark/cross_join.q.out 2740c1803bd9421b8fc6c77182a1b1438fc4b368 > ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 65f0c22002f7e2d6ba732dcc4a055fd506e98cb2 > ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 26bee4ef467648516ff372c448d34ebe311e5e50 > ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 816377397655ec50eff97bcb0fa75abd2fadb213 > ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out a21ea9c334684b9e43ec6c613be6b5fcd5782d3e > ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out d0f5952ab5f968ea3163db8e06a18e8bd80132ff > ql/src/test/results/clientpositive/spark/join38.q.out 71d59e2b3bc3ccc251ae53581f80c1a3bb4b3752 > ql/src/test/results/clientpositive/spark/join8.q.out 270053c9769fcccdf0347f311c7186969f1ea4f0 > ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out 2c8034f4c45598a62aec728c44e5bec483b916ef > ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out 0610d135912a2275250b5927e216e4566b9cdcb1 > ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out 0e748fb013a8ace2b0f266d5a33d886cfa51a8a6 > ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out 45fba92f9f9ed418c770ad3036ed79363c08c385 > ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out 9211cb6cc0cd294ce479f2c16cb60ac49158e1ac > ql/src/test/results/clientpositive/spark/join_filters_overlap.q.out 2d5d7c1a6343692dc0cc1de3c977e988ce6f42d3 > ql/src/test/results/clientpositive/spark/join_reorder.q.out df6a36e54a726dfca5d6b776287aab1c3d7f327d > ql/src/test/results/clientpositive/spark/join_view.q.out 14a28bee42d08e5a919c01313ad74226a673fee6 > ql/src/test/results/clientpositive/spark/pcr.q.out 21b7519d3b264ac3b52cecb83832178b03efe4a3 > ql/src/test/results/clientpositive/spark/ppd_join5.q.out 1c2b59262e5fd79136406ef34a269b61f7aeddcf > ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 312b3bd3cdfbb56f8b8c81bb49fc58f9702cd647 > ql/src/test/results/clientpositive/spark/ppd_outer_join5.q.out ef8c674ca3d9ac6f4d9dbcace1c428dbdb474e12 > ql/src/test/results/clientpositive/spark/skewjoin.q.out 147599519f15a4f301fd45b1611792b11c64d2b5 > ql/src/test/results/clientpositive/spark/smb_mapjoin_25.q.out 4b392ba24d901f0d36cecc95bf3a717d29501ebb > ql/src/test/results/clientpositive/spark/table_access_keys_stats.q.out bbf24fdb1d564423040082a21d2d85d16482d89b > ql/src/test/results/clientpositive/spark/union_view.q.out 3372afb890ec5abd69e7d3bf2274c58bc44d7e19 > ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 8b3d353f8d4e9f1473e5b7c79210357c45f00896 > ql/src/test/results/clientpositive/spark/vector_outer_join1.q.out 50134d96b791435d9344b482c47f08e38a78fab0 > ql/src/test/results/clientpositive/spark/vector_outer_join2.q.out dba7cbd4aa77925fd89243f600aeb8460a26ea45 > ql/src/test/results/clientpositive/spark/vector_outer_join3.q.out 1c3b7a6b9920d98cb1fa1cbc55ae58381a77eb04 > ql/src/test/results/clientpositive/spark/vector_outer_join4.q.out cc1db389ede152f55d09b402247fda8a9450e2f0 > ql/src/test/results/clientpositive/spark/vector_outer_join5.q.out 8c065f2c511bfb25c307a3c5714d96fe09068a6a > ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 7caa50d32954d17387cb102ffaead46bfd25f76d > ql/src/test/results/clientpositive/subquery_notin.q.out c600b7f9f03791087322211dec755eacd1023907 > ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 5114296d41c7e8aafc95f316b9069dd0e52daf39 > ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 7853737de3155cfcd8e91cee6dfd5598c7039f04 > ql/src/test/results/clientpositive/subquery_views.q.out fab919dd41e8d04e3529cdc35cc0be1ebe479911 > ql/src/test/results/clientpositive/table_access_keys_stats.q.out bbf24fdb1d564423040082a21d2d85d16482d89b > ql/src/test/results/clientpositive/tez/auto_join_filters.q.out 1559d4b34bea9867884236253dc3cd7dd6f14ffc > ql/src/test/results/clientpositive/tez/auto_join_nulls.q.out 5b68bb73f218ac5224da2b2fcc0d0fd53e368572 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_12.q.out dfcf7eacca28d2329c62e235c4641a5e0dcb14c5 > ql/src/test/results/clientpositive/tez/constprog_semijoin.q.out 636410acbac25aa51d4f21c13ed7fe7dc6a5656b > ql/src/test/results/clientpositive/tez/cross_join.q.out 0fa801e6704706526dc3ed2138f98a1cc91ce9e9 > ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out 470590acdb634f224599083d284ee279315dbdfb > ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out 68df37d5c12e8231200c2bfcc41a6f76e9b61a95 > ql/src/test/results/clientpositive/tez/cte_mat_1.q.out bbe429642b6e31d62a758e5d68bf6bfac50f4ef4 > ql/src/test/results/clientpositive/tez/cte_mat_2.q.out bbe429642b6e31d62a758e5d68bf6bfac50f4ef4 > ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 262676845b0dda05503fc583c0e63bc1bec25fa4 > ql/src/test/results/clientpositive/tez/dynamic_partition_pruning_2.q.out 71b7ee3e7691ad3b8ebfc0bfc99ebdec31147c13 > ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out 2f88148db5d123caf3d3dd81cf7cfc9b4cddd2df > ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 97f59d9ecdb510200f5234912741699ca9ac046f > ql/src/test/results/clientpositive/tez/explainuser_1.q.out 965577e428b428024d3daa51fcd2413e26360493 > ql/src/test/results/clientpositive/tez/explainuser_4.q.out 661f95f21b61a1bb41474ace127a1c2790e05363 > ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_1.q.out 7c22d9a7f16b10bc34288b2f6c0e73b7703a40d6 > ql/src/test/results/clientpositive/tez/mergejoin.q.out 299c4dbe8c17a445d2f0f207ffaab307f184aaf8 > ql/src/test/results/clientpositive/tez/skewjoin.q.out 0ee28fb8326f3677c4e2e43f6e647aa8d3154ef8 > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_1.q.out eb40bd7d7e454dc75e8b84d160016e4e3bee77f5 > ql/src/test/results/clientpositive/tez/tez_self_join.q.out f5375b279c1f04ed8ddf98a192f427b68ffdf3a6 > ql/src/test/results/clientpositive/tez/tez_union_dynamic_partition.q.out abb0707ca5aa3df77a60199d4dbd53a377738446 > ql/src/test/results/clientpositive/tez/tez_vector_dynpart_hashjoin_1.q.out 47699c651855fbc8282e271b2e8b531305a92b58 > ql/src/test/results/clientpositive/tez/union_fast_stats.q.out 578205eaa6d6e47e6f20cd10133ceff738e49786 > ql/src/test/results/clientpositive/tez/vector_between_columns.q.out d548364c8a64c01895b5fac72a716fb854f03cbd > ql/src/test/results/clientpositive/tez/vector_binary_join_groupby.q.out 2bf93e3e2e49476251c90f2669c81b68ee9ed771 > ql/src/test/results/clientpositive/tez/vector_coalesce.q.out bb670082fef7e3e57cbd654ef3acc7baf1611171 > ql/src/test/results/clientpositive/tez/vector_date_1.q.out a27edcb6d9df2e0e288b5e9d5ff5eda5694fe820 > ql/src/test/results/clientpositive/tez/vector_decimal_2.q.out 701f0b7164619f2e84160e7a1e3ea467f318a546 > ql/src/test/results/clientpositive/tez/vector_decimal_round_2.q.out a7b8385dd42da627a0c3f080362491bd6cc419cd > ql/src/test/results/clientpositive/tez/vector_groupby_mapjoin.q.out d406f2bb83f0dd2c3a520af5910f9c9eaa27bc33 > ql/src/test/results/clientpositive/tez/vector_interval_1.q.out dbfa84274a32eaef5d8f6d205cdeb7cef92bbbe9 > ql/src/test/results/clientpositive/tez/vector_interval_arithmetic.q.out 8409a015f2d288b36dd6c640ba09163fae72d438 > ql/src/test/results/clientpositive/tez/vector_join_filters.q.out d50e0797efedb048c888a003fff3e221d240a7c2 > ql/src/test/results/clientpositive/tez/vector_join_nulls.q.out 97b3242338070be5f2223f81fcbd555fa3bb1f3f > ql/src/test/results/clientpositive/tez/vector_mapjoin_reduce.q.out 2864a48971f8c34f62fc2182433b1da26bf3c27d > ql/src/test/results/clientpositive/tez/vector_null_projection.q.out a4ccef217b13375c3cb4df06ddcc96f2a6a8e448 > ql/src/test/results/clientpositive/tez/vector_outer_join1.q.out 946a558aa18dbe53f5eed74fdbff4fc1bc9a9038 > ql/src/test/results/clientpositive/tez/vector_outer_join2.q.out 19983449a46951fc2837a92cf3f91c9584539f7e > ql/src/test/results/clientpositive/tez/vector_outer_join3.q.out f20163b04e498b543e798b45a38b9aec8074e7e6 > ql/src/test/results/clientpositive/tez/vector_outer_join4.q.out 90a9efbe94535ade9b879498d37a242962e01040 > ql/src/test/results/clientpositive/tez/vector_outer_join5.q.out c1c251fd5de5782f94b68ca688a59dd36e1f8fd1 > ql/src/test/results/clientpositive/tez/vectorization_short_regress.q.out 70f8d1bdbe2100fd42ed209e114d1112c42475d3 > ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out a790b97b2af50b3c40b15eaec0c6322a4c27b38c > ql/src/test/results/clientpositive/udf_folder_constants.q.out 3e765d99c58fc1586b8ca2c8420b12670fb5b320 > ql/src/test/results/clientpositive/udf_unix_timestamp.q.out 1aa9727c5785d510516deb25d1748f8f47c8e25c > ql/src/test/results/clientpositive/union_fast_stats.q.out f0879af3fd3a1900b889e09ab754f9304a9e25d1 > ql/src/test/results/clientpositive/union_offcbo.q.out 7eff464d4c7b56f9a0cc1994723a604358ec86a3 > ql/src/test/results/clientpositive/union_remove_12.q.out 2b425388e6ee3a0f7a80e634f83515124e5d063c > ql/src/test/results/clientpositive/union_remove_14.q.out a754dd45c5a264c261b60d7422f262e42c3290b7 > ql/src/test/results/clientpositive/union_view.q.out 530739e374a04fd71e6f136060e90f9d603478ea > ql/src/test/results/clientpositive/unionall_unbalancedppd.q.out ba3a0b8e6e74590a988e7fe1ee1c6da8b99924ec > ql/src/test/results/clientpositive/vector_between_columns.q.out 5faa79b53342a0720aeee983b61bde3f480609e2 > ql/src/test/results/clientpositive/vector_binary_join_groupby.q.out 2169db9edb8211d02ed6257c3d3b34c26b89300c > ql/src/test/results/clientpositive/vector_coalesce.q.out e126dcb056b63ca7425ebf0fc592401826dfa8e7 > ql/src/test/results/clientpositive/vector_date_1.q.out da608bf7cb0bf29fd4bced7f7cc05c55efb5f68f > ql/src/test/results/clientpositive/vector_decimal_2.q.out 5e5b36c8c49b88fefdd14382e1341fd3a825d7f2 > ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out d367b1e1874148d08dce8771b985e36a17b074e1 > ql/src/test/results/clientpositive/vector_interval_1.q.out 68456283ea1f737c9fa77a2384d1a6dd64bed17e > ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out cd8111d4a68ce3c88e329c55d9bdc7fba86ad072 > ql/src/test/results/clientpositive/vector_join_filters.q.out 999fee7f3533f5f75c100df586ef28631e20412b > ql/src/test/results/clientpositive/vector_join_nulls.q.out 9011a1f6943048cd03f6fe6f6df16a72ea7a66e1 > ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out 20f79c1e19006da011a580c6dd726cc2824ed2ee > ql/src/test/results/clientpositive/vector_null_projection.q.out 7517cc29015903a0b72f748a96520fc9afae7e93 > ql/src/test/results/clientpositive/vector_number_compare_projection.q.out 85f7cc8901d4b0ec7237e13b5c1b296076326313 > ql/src/test/results/clientpositive/vector_outer_join1.q.out 93ab47342d9c1d53b0eb0fbcf062615ead2f1326 > ql/src/test/results/clientpositive/vector_outer_join2.q.out c8001e06bd049effe8f32597f2e0e3b667f59bce > ql/src/test/results/clientpositive/vector_outer_join3.q.out 4f1a98d8f9e04afb085572a349cf41c5c3a34506 > ql/src/test/results/clientpositive/vector_outer_join4.q.out a32f585820eb09e160558d58963f1122074f7dca > ql/src/test/results/clientpositive/vector_outer_join5.q.out 1b09fda226e2622cf779d04985be3720e80a311e > ql/src/test/results/clientpositive/vectorization_short_regress.q.out 7691dda4ade6bb01de98497ef6afa57821b41539 > > Diff: https://reviews.apache.org/r/46690/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > > --===============8174713327200428546==--