Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F1B3E2009F3 for ; Sat, 21 May 2016 02:03:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F02CA160A2A; Sat, 21 May 2016 00:03:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 44CBF160A25 for ; Sat, 21 May 2016 02:03:10 +0200 (CEST) Received: (qmail 97549 invoked by uid 500); 21 May 2016 00:03:04 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 97531 invoked by uid 99); 21 May 2016 00:03:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 May 2016 00:03:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 993262C1E71; Sat, 21 May 2016 00:03:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5739600986480330772==" MIME-Version: 1.0 Subject: Re: Review Request 46956: HIVE-13444 LLAP: add HMAC signatures to LLAP; verify them on LLAP side From: Sergey Shelukhin To: Gunther Hagleitner , Jason Dere , Siddharth Seth Cc: Sergey Shelukhin , hive Date: Sat, 21 May 2016 00:03:03 -0000 Message-ID: <20160521000303.19667.44083@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sergey Shelukhin X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46956/ X-Sender: Sergey Shelukhin References: <20160520022104.1678.56230@reviews.apache.org> In-Reply-To: <20160520022104.1678.56230@reviews.apache.org> X-ReviewBoard-Diff-For: llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSigner.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java X-ReviewBoard-Diff-For: llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java Reply-To: Sergey Shelukhin X-ReviewRequest-Repository: hive-git archived-at: Sat, 21 May 2016 00:03:11 -0000 --===============5739600986480330772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 20, 2016, 2:21 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTokenChecker.java, line 25 > > > > > > Think the patch which added Pair/ImmutablePair may have added a maven dependency. Should be removed if it was added explicitly for this. it has since become necessary for StringUtils - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46956/#review134076 ----------------------------------------------------------- On May 18, 2016, 8:36 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46956/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 8:36 p.m.) > > > Review request for hive, Gunther Hagleitner, Jason Dere, and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cbb3a72 > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java f10351b > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSigner.java PRE-CREATION > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java e28eddd > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java PRE-CREATION > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java 465b204 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 2524dc2 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java de817e3 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java b94fc2e > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTokenChecker.java 03ee055 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 8abd198 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java eac0e8f > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java 74359fa > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java PRE-CREATION > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java 279baf1 > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapTokenChecker.java aaaa762 > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java a250882 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java c9b912b > > Diff: https://reviews.apache.org/r/46956/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============5739600986480330772==--