Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============4938424082386850427=="
MIME-Version: 1.0
Subject: Re: Review Request 47353: HIVE-13616: Investigate renaming a table
 without invalidating the column stats
From: Aihua Xu <axu@cloudera.com>
To: Chaoyu Tang <ctang.ma@gmail.com>
Cc: Ashutosh Chauhan <hashutosh@apache.org>, hive <dev@hive.apache.org>,
 Aihua Xu <axu@cloudera.com>
Date: Tue, 17 May 2016 13:26:01 -0000
Message-ID: <20160517132601.8624.48139@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Aihua Xu <noreply@reviews.apache.org>
References: <20160516211745.8624.29259@reviews.apache.org>
In-Reply-To: <20160516211745.8624.29259@reviews.apache.org>
Reply-To: Aihua Xu <axu@cloudera.com>
archived-at: Tue, 17 May 2016 13:26:04 -0000

--===============4938424082386850427==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On May 16, 2016, 9:17 p.m., Ashutosh Chauhan wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java, line 651
> > <https://reviews.apache.org/r/47353/diff/1/?file=1382994#file1382994line651>
> >
> >     Refer to ObjectStore::createDatabase(), createTable(), convertToMTable() which have this logic.

Changed to toLowerCase(). I will try to fix the inconsistency in a followup.


- Aihua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47353/#review133446
-----------------------------------------------------------


On May 17, 2016, 1:25 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47353/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 1:25 p.m.)
> 
> 
> Review request for hive and Chaoyu Tang.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13616: Investigate renaming a table without invalidating the column stats
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 0652b9d 
>   ql/src/test/queries/clientpositive/rename_table_update_column_stats.q PRE-CREATION 
>   ql/src/test/results/clientpositive/rename_table_update_column_stats.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47353/diff/
> 
> 
> Testing
> -------
> 
> Tests have been run and the failed tests don't seem to be related. 
> 
> To carry over the column stats during renaming the table, the patch 
> 1. Save affected column stats
> 2. Rename the table
> 3. Write the saved column stats for the new table.
> 
> In this order, column stats will find the foreign key when writing in 3).
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


--===============4938424082386850427==--