Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32B212009FB for ; Fri, 6 May 2016 23:29:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 31471160A0C; Fri, 6 May 2016 21:29:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F38F1608F8 for ; Fri, 6 May 2016 23:29:42 +0200 (CEST) Received: (qmail 8237 invoked by uid 500); 6 May 2016 21:29:41 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 8221 invoked by uid 99); 6 May 2016 21:29:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 May 2016 21:29:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 777532B6010; Fri, 6 May 2016 21:29:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2973294673924133124==" MIME-Version: 1.0 Subject: Re: Review Request 45911: HIVE-13341: Stats state is not captured correctly: differentiate load table and create table From: pengcheng xiong To: Ashutosh Chauhan Cc: pengcheng xiong , hive Date: Fri, 06 May 2016 21:29:40 -0000 Message-ID: <20160506212940.2047.71678@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: pengcheng xiong X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45911/ X-Sender: pengcheng xiong References: <20160503204046.19045.24560@reviews.apache.org> In-Reply-To: <20160503204046.19045.24560@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/alter_table_add_partition.q X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/alter_table_add_partition.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/insert_values_orig_table_use_metadata.q.out Reply-To: pengcheng xiong X-ReviewRequest-Repository: hive-git archived-at: Fri, 06 May 2016 21:29:43 -0000 --===============2973294673924133124== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45911/ ----------------------------------------------------------- (Updated May 6, 2016, 9:29 p.m.) Review request for hive and Ashutosh Chauhan. Changes ------- more golden file updates. Repository: hive-git Description ------- HIVE-13341: Stats state is not captured correctly: differentiate load table and create table Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 41d150c data/scripts/q_test_cleanup.sql 4620dcd data/scripts/q_test_init.sql 0c8668c itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java c046708 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 76220f4 ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java c2c6c65 ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 87a7667 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f4a9772 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 4a6617f ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 500c7ed ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 2dc4e11 ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 667d5c2 ql/src/test/queries/clientpositive/alter_table_add_partition.q PRE-CREATION ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q PRE-CREATION ql/src/test/queries/clientpositive/stats20.q 59701bd ql/src/test/results/clientnegative/alter_file_format.q.out 96f1bfb ql/src/test/results/clientnegative/unset_table_property.q.out 0510788 ql/src/test/results/clientpositive/alter_file_format.q.out 5d83b23 ql/src/test/results/clientpositive/alter_skewed_table.q.out a1caa99 ql/src/test/results/clientpositive/alter_table_add_partition.q.out PRE-CREATION ql/src/test/results/clientpositive/alter_table_not_sorted.q.out 6e1ec59 ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 0902556 ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 81de2b0 ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 26a11a7 ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 78cd03d ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 7ddf6b3 ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 5b68da2 ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 07bcb89 ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out d12c1ca ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 23a3685 ql/src/test/results/clientpositive/binary_output_format.q.out 608d475 ql/src/test/results/clientpositive/bucket1.q.out 96b8d4e ql/src/test/results/clientpositive/bucket2.q.out b5572fd ql/src/test/results/clientpositive/bucket4.q.out c4baf72 ql/src/test/results/clientpositive/bucket5.q.out dee79f9 ql/src/test/results/clientpositive/bucket_many.q.out 90d9fb8 ql/src/test/results/clientpositive/bucket_map_join_1.q.out 49bf2ca ql/src/test/results/clientpositive/bucket_map_join_2.q.out 9ec7033 ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out 19937cb ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out 90528be ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out aede979 ql/src/test/results/clientpositive/bucketcontext_1.q.out d1b7744 ql/src/test/results/clientpositive/bucketcontext_2.q.out 60c021c ql/src/test/results/clientpositive/bucketcontext_3.q.out 12eaddf ql/src/test/results/clientpositive/bucketcontext_4.q.out 2573564 ql/src/test/results/clientpositive/bucketcontext_5.q.out e1c6a80 ql/src/test/results/clientpositive/bucketcontext_6.q.out 9deb64d ql/src/test/results/clientpositive/bucketcontext_7.q.out 621844e ql/src/test/results/clientpositive/bucketcontext_8.q.out 7f3e50a ql/src/test/results/clientpositive/bucketmapjoin1.q.out 9956fa7 ql/src/test/results/clientpositive/bucketmapjoin10.q.out fcdbb09 ql/src/test/results/clientpositive/bucketmapjoin11.q.out 968066a ql/src/test/results/clientpositive/bucketmapjoin12.q.out 9017871 ql/src/test/results/clientpositive/bucketmapjoin2.q.out f2efb95 ql/src/test/results/clientpositive/bucketmapjoin3.q.out 5659983 ql/src/test/results/clientpositive/bucketmapjoin4.q.out 5794d47 ql/src/test/results/clientpositive/bucketmapjoin5.q.out 1bcb382 ql/src/test/results/clientpositive/bucketmapjoin7.q.out 76b13f3 ql/src/test/results/clientpositive/bucketmapjoin8.q.out 097eaad ql/src/test/results/clientpositive/bucketmapjoin9.q.out 144d86d ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out d108575 ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out 9c6a226 ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out 3078854 ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_1.q.out 8c9664d ql/src/test/results/clientpositive/column_names_with_leading_and_trailing_spaces.q.out 46c285e ql/src/test/results/clientpositive/columnstats_partlvl.q.out 4edf39a ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 669807d ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out c4f51a3 ql/src/test/results/clientpositive/create_like.q.out 9241b68 ql/src/test/results/clientpositive/create_like_view.q.out e2dc2c4 ql/src/test/results/clientpositive/create_skewed_table1.q.out 415bb77 ql/src/test/results/clientpositive/database_location.q.out 797177d ql/src/test/results/clientpositive/default_file_format.q.out 3d5c20f ql/src/test/results/clientpositive/describe_comment_indent.q.out 3e0f45e ql/src/test/results/clientpositive/describe_comment_nonascii.q.out df0b65e ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out c4dbf17 ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 1028c26 ql/src/test/results/clientpositive/groupby_map_ppr.q.out 3d07b0d ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out 6689225 ql/src/test/results/clientpositive/groupby_ppr.q.out 62fffbe ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out 2408056 ql/src/test/results/clientpositive/groupby_sort_1_23.q.out a6e15ba ql/src/test/results/clientpositive/groupby_sort_6.q.out f523085 ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 38b24a4 ql/src/test/results/clientpositive/input_part1.q.out 2abaa3b ql/src/test/results/clientpositive/input_part2.q.out 2ce071c ql/src/test/results/clientpositive/insert_values_orig_table_use_metadata.q.out PRE-CREATION ql/src/test/results/clientpositive/join17.q.out 39c49a5 ql/src/test/results/clientpositive/join26.q.out 0fdc403 ql/src/test/results/clientpositive/join32.q.out aad5463 ql/src/test/results/clientpositive/join32_lessSize.q.out a94b951 ql/src/test/results/clientpositive/join33.q.out aad5463 ql/src/test/results/clientpositive/join34.q.out 74fac5c ql/src/test/results/clientpositive/join35.q.out 6fe9cae ql/src/test/results/clientpositive/join9.q.out f41d153 ql/src/test/results/clientpositive/join_map_ppr.q.out e720e65 ql/src/test/results/clientpositive/list_bucket_dml_14.q.out c063dc1 ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.7.out d40a693 ql/src/test/results/clientpositive/mapjoin_memcheck.q.out 8f5492f ql/src/test/results/clientpositive/nullformat.q.out af91470 ql/src/test/results/clientpositive/orc_create.q.out 3013fda ql/src/test/results/clientpositive/orc_llap.q.out 6fc73b7 ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 7b361b7 ql/src/test/results/clientpositive/parquet_array_null_element.q.out 387f01e ql/src/test/results/clientpositive/parquet_create.q.out c6d33ff ql/src/test/results/clientpositive/parquet_mixed_partition_formats.q.out d6affd6 ql/src/test/results/clientpositive/parquet_serde.q.out c1e594a ql/src/test/results/clientpositive/pcr.q.out b53226e ql/src/test/results/clientpositive/rand_partitionpruner2.q.out d88c53d ql/src/test/results/clientpositive/rcfile_default_format.q.out c961231 ql/src/test/results/clientpositive/reduce_deduplicate.q.out 379f884 ql/src/test/results/clientpositive/sample1.q.out e188902 ql/src/test/results/clientpositive/sample2.q.out 9653c41 ql/src/test/results/clientpositive/sample4.q.out a9730b1 ql/src/test/results/clientpositive/sample5.q.out d5ff403 ql/src/test/results/clientpositive/sample6.q.out ea71ad6 ql/src/test/results/clientpositive/sample7.q.out 94618e5 ql/src/test/results/clientpositive/schema_evol_orc_nonvec_fetchwork_table.q.out 912463b ql/src/test/results/clientpositive/schema_evol_orc_nonvec_mapwork_table.q.out f007ba8 ql/src/test/results/clientpositive/schema_evol_orc_vec_mapwork_table.q.out a305847 ql/src/test/results/clientpositive/schema_evol_text_nonvec_mapwork_table.q.out 7a7e068 ql/src/test/results/clientpositive/schema_evol_text_vec_mapwork_table.q.out 50328d3 ql/src/test/results/clientpositive/schema_evol_text_vecrow_mapwork_table.q.out 50790f4 ql/src/test/results/clientpositive/show_create_table_alter.q.out 32819ea ql/src/test/results/clientpositive/show_create_table_db_table.q.out 495f4b5 ql/src/test/results/clientpositive/show_create_table_serde.q.out 2350d98 ql/src/test/results/clientpositive/show_tblproperties.q.out 63bbe6d ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out dfb571d ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out 76ea0a8 ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out c942d11 ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out ba2547a ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out 99fca25 ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out 00c601f ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out 5564ceb ql/src/test/results/clientpositive/spark/bucket2.q.out aa47459 ql/src/test/results/clientpositive/spark/bucket4.q.out 680cee7 ql/src/test/results/clientpositive/spark/bucket_map_join_1.q.out 299cedf ql/src/test/results/clientpositive/spark/bucket_map_join_2.q.out f330bf2 ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out b32528c ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out 7b304c5 ql/src/test/results/clientpositive/spark/bucket_map_join_spark3.q.out 4265d1a ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out c6a7f0e ql/src/test/results/clientpositive/spark/bucketmapjoin10.q.out 0e3b5c7 ql/src/test/results/clientpositive/spark/bucketmapjoin11.q.out 38f9785 ql/src/test/results/clientpositive/spark/bucketmapjoin12.q.out 55ded7d ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out 48ff95f ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 95589ca ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out fba617c ql/src/test/results/clientpositive/spark/bucketmapjoin5.q.out 7214b42 ql/src/test/results/clientpositive/spark/bucketmapjoin7.q.out d344070 ql/src/test/results/clientpositive/spark/bucketmapjoin8.q.out a7ad6de ql/src/test/results/clientpositive/spark/bucketmapjoin9.q.out 6e4c536 ql/src/test/results/clientpositive/spark/bucketmapjoin_negative.q.out 9fff7b2 ql/src/test/results/clientpositive/spark/bucketmapjoin_negative2.q.out b199ad9 ql/src/test/results/clientpositive/spark/bucketmapjoin_negative3.q.out 845e450 ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out e21b1b1 ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 1b4822e ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 0956771 ql/src/test/results/clientpositive/spark/join17.q.out 0d92441 ql/src/test/results/clientpositive/spark/mapjoin_memcheck.q.out 2f41847 ql/src/test/results/clientpositive/spark/stats0.q.out e741320 ql/src/test/results/clientpositive/spark/stats20.q.out d7e52b4 ql/src/test/results/clientpositive/spark/stats3.q.out 4dbda94 ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out 7b56585 ql/src/test/results/clientpositive/stats0.q.out 90a9a70 ql/src/test/results/clientpositive/stats1.q.out 72c53e3 ql/src/test/results/clientpositive/stats11.q.out 8ca5b27 ql/src/test/results/clientpositive/stats18.q.out 6971e44 ql/src/test/results/clientpositive/stats20.q.out d7e52b4 ql/src/test/results/clientpositive/stats3.q.out 4dbda94 ql/src/test/results/clientpositive/tez/auto_sortmerge_join_1.q.out 892539d ql/src/test/results/clientpositive/tez/auto_sortmerge_join_11.q.out 954fd96 ql/src/test/results/clientpositive/tez/auto_sortmerge_join_12.q.out 578880d ql/src/test/results/clientpositive/tez/auto_sortmerge_join_2.q.out c283738 ql/src/test/results/clientpositive/tez/auto_sortmerge_join_3.q.out 351fd20 ql/src/test/results/clientpositive/tez/auto_sortmerge_join_4.q.out 2d9cdf8 ql/src/test/results/clientpositive/tez/auto_sortmerge_join_5.q.out 8bc203a ql/src/test/results/clientpositive/tez/auto_sortmerge_join_7.q.out 18fc95c ql/src/test/results/clientpositive/tez/auto_sortmerge_join_8.q.out 9a1010c ql/src/test/results/clientpositive/tez/bucket2.q.out e9432a8 ql/src/test/results/clientpositive/tez/bucket4.q.out a0f1177 ql/src/test/results/clientpositive/tez/column_names_with_leading_and_trailing_spaces.q.out 46c285e ql/src/test/results/clientpositive/tez/disable_merge_for_bucketing.q.out bb62e1f ql/src/test/results/clientpositive/tez/explainuser_1.q.out bdb8830 ql/src/test/results/clientpositive/tez/sample1.q.out 009969e ql/src/test/results/clientpositive/tez/schema_evol_orc_nonvec_fetchwork_table.q.out 8a9481f ql/src/test/results/clientpositive/tez/schema_evol_orc_nonvec_mapwork_table.q.out 39954b8 ql/src/test/results/clientpositive/tez/schema_evol_orc_vec_mapwork_table.q.out ca292b1 ql/src/test/results/clientpositive/tez/schema_evol_text_nonvec_mapwork_table.q.out 14abca9 ql/src/test/results/clientpositive/tez/schema_evol_text_vec_mapwork_table.q.out 2b799f9 ql/src/test/results/clientpositive/tez/schema_evol_text_vecrow_mapwork_table.q.out 1b46fa7 ql/src/test/results/clientpositive/tez/tez_join_result_complex.q.out 3e3b08c ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out 1365626 ql/src/test/results/clientpositive/truncate_column.q.out adbddfa ql/src/test/results/clientpositive/truncate_column_list_bucket.q.out 39ffc6c ql/src/test/results/clientpositive/unicode_notation.q.out 52da674 ql/src/test/results/clientpositive/unset_table_view_property.q.out 8bbb9fe ql/src/test/results/clientpositive/vectorized_ptf.q.out fc4351d Diff: https://reviews.apache.org/r/45911/diff/ Testing ------- Thanks, pengcheng xiong --===============2973294673924133124==--