hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongzhi Chen <yc...@cloudera.com>
Subject Re: Review Request 47787: HIVE-13453: Support ORDER BY and windowing clause in partitioning clause with distinct function
Date Wed, 25 May 2016 16:47:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47787/#review134784
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java (line 169)
<https://reviews.apache.org/r/47787/#comment199690>

    How do you handle countDistinct non windowing case?


- Yongzhi Chen


On May 24, 2016, 6:51 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47787/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 6:51 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13453: Support ORDER BY and windowing clause in partitioning clause with distinct
function
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 2f4a94c3796d3aff986eb638246248b75306183c

>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 3b54b4998c9efbf34bd9c5b08de55cd7062a0843

>   ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 5ce72004e03bc19a38bd87ae70f38a0d35c20927

>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFunctionDef.java ed6c67156b93d6f9e4b76fb76dfa28c5dee6fd0c

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 3c1ce26b26646a6075b3a661816e8d1b50ffc78e

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java 2825045890de1bcc414197ad3e06e723b9d212f3

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFParameterInfo.java 6a62d7cc324286ae9aee95d2d71a688859f8c03f

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 7b1d6e545cdf35f3b2906621c7b0208bf0433731

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/SimpleGenericUDAFParameterInfo.java
1a1b570256afff46761daf4ebcf1da5e8f0e4f88 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 858b47ad43fa751e23482e4cb58f77bb9fb16a27

>   ql/src/test/queries/clientpositive/windowing_distinct.q bb192a7882fda592b3d2ba09a10c2f899aa5e165

>   ql/src/test/results/clientpositive/windowing_distinct.q.out 074a59498ebebc9e78553f68f59dd00bb51f4792

>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
c58e8ed05453c78cbe2e4daf0b7afa51adbc0ce9 
> 
> Diff: https://reviews.apache.org/r/47787/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message