hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reuben Kuhnert <sircodesa...@gmail.com>
Subject Re: Review Request 47040: Monitor changes to FairScheduler.xml file and automatically update / validate jobs submitted to fair-scheduler
Date Tue, 24 May 2016 11:58:00 GMT


> On May 17, 2016, 6:44 p.m., Yongzhi Chen wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 533
> > <https://reviews.apache.org/r/47040/diff/10/?file=1384158#file1384158line533>
> >
> >     This if statement is duplicate with the Precondition. If you want to throw exception,only
use Precondition, otherwise, just use if statement. Use both will end up checking the same
condition twice.

This is correct. One is for checking that we're in a valid state. The other is for throwing
if the user tries to call the function in an invalid state. Thanks!


- Reuben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47040/#review133592
-----------------------------------------------------------


On May 24, 2016, 11:56 a.m., Reuben Kuhnert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47040/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 11:56 a.m.)
> 
> 
> Review request for hive, Lenni Kuff, Mohit Sabharwal, and Sergio Pena.
> 
> 
> Bugs: HIVE-13696
>     https://issues.apache.org/jira/browse/HIVE-13696
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Ensure that jobs sent to YARN with impersonation off are correctly routed to the proper
queue based on fair-scheduler.xml. Monitor this file for changes and validate that jobs can
only be sent to queues authorized for the user.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 3fecc5c4ca2a06a031c0c4a711fb49e757c49062

>   ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java PRE-CREATION

>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java a0015ebc655931f241b28c53fbb94cfe172841b1

>   shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java 63803b8b0752745bd2fedaccc5d100befd97093b

>   shims/scheduler/pom.xml b36c12325c588cdb609c6200b1edef73a2f79552 
>   shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerQueueAllocator.java
PRE-CREATION 
>   shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java
372244dc3c989d2a3ae2eb2bfb8cd0a235705e18 
>   shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/QueueAllocator.java PRE-CREATION

>   shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairSchedulerQueueAllocator.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47040/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message