hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Siddharth Seth <ss...@apache.org>
Subject Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data
Date Mon, 23 May 2016 20:54:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46754/#review134432
-----------------------------------------------------------



Any possibility of simple unit tests ?


llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapUgiFactoryFactory.java (line
36)
<https://reviews.apache.org/r/46754/#comment199242>

    Lets skip the reflection, and create a single UGI for now.
    
    A follow up jira to create a UGI pool should take care of the potential single UGI perf
issue.


- Siddharth Seth


On May 20, 2016, 1:49 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46754/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 1:49 a.m.)
> 
> 
> Review request for hive and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/UgiFactory.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9cc8fbe 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
cffa493 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
2524dc2 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java de817e3

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java
74359fa 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java fea3dc7

>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java
b3b571d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapUgiFactoryFactory.java
PRE-CREATION 
>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
279baf1 
>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java
a250882 
> 
> Diff: https://reviews.apache.org/r/46754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message