hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 47554: HIVE-13750
Date Thu, 19 May 2016 00:06:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47554/#review133844
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (line
517)
<https://reviews.apache.org/r/47554/#comment198496>

    This is already called, before a call to procesDynP..
    Do we need it again?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (line
536)
<https://reviews.apache.org/r/47554/#comment198497>

    Can you add comments what are permissible operator sequences here?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (line
554)
<https://reviews.apache.org/r/47554/#comment198493>

    Can you also add comment why this is valid only for RS added by SPDO and not in general?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (line
582)
<https://reviews.apache.org/r/47554/#comment198494>

    Currently, _buceket_number_ comes in as constant when it really its not. Will that break
assumption about ignoring constant?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java (lines
738 - 742)
<https://reviews.apache.org/r/47554/#comment198490>

    Should it be other way round? That we first try normal dedup and then extended.


- Ashutosh Chauhan


On May 18, 2016, 9:42 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47554/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 9:42 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-13750
>     https://issues.apache.org/jira/browse/HIVE-13750
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13750
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java 010c89ed978296709b052cc7bc80256a27658e2b

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
733620b84657a21829248afe72ab16ad9692f37e 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java d7e404c9946461e20357ed53dd8da468590683c6

>   ql/src/test/results/clientpositive/dynpart_sort_opt_vectorization.q.out d03bfe422743d9a5a6b85f9a6198e1e27024f129

>   ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out dec872ab0eef54bd92d5c2bc068e2805cc14e272

>   ql/src/test/results/clientpositive/dynpart_sort_optimization_acid.q.out 832580325873dee741ba86239ee571873994a808

>   ql/src/test/results/clientpositive/tez/dynpart_sort_opt_vectorization.q.out a90e3f63b4646cf0ade9785a501ebd1a6b2a3406

>   ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out 723e8192f2735059005fc3c5c96732a2c4be49c1

> 
> Diff: https://reviews.apache.org/r/47554/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message