hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 47392: HIVE-13269
Date Tue, 17 May 2016 11:22:06 GMT


> On May 16, 2016, 9:07 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java,
line 253
> > <https://reviews.apache.org/r/47392/diff/1/?file=1384342#file1384342line253>
> >
> >     You may want to use StatsSetupConst.areColumnStatsUptoDate(tbl.getParameters(),
colName) to ascertain column stats can be trusted.

_table.getColStat_ (in the following line) calls _updateColStats_ to update the column stats.
Thus, I think the call to _areColumnStatsUptoDate_ is not necessary?


- Jesús


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47392/#review133439
-----------------------------------------------------------


On May 15, 2016, 5:48 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47392/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 5:48 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-13269
>     https://issues.apache.org/jira/browse/HIVE-13269
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13269
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 541af577e85ff37b509d06ba843911e765383adf

>   data/conf/perf-reg/hive-site.xml 9e929fcdcb1fecc7ff8b9d40dd4e25fd92850616 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 2f309f3de6acfac09b7b0d84cbb9d4275e317aeb

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java de6a053a5b299ee39ec9af865d077a886497189f

>   ql/src/test/queries/clientpositive/remove_exprs_stats.q PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query88.q.out e3f69d3b4739ebfb692c3b8a5aa343b539bb0906

>   ql/src/test/results/clientpositive/remove_exprs_stats.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47392/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message