hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 47242: HIVE-13726
Date Thu, 12 May 2016 05:48:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47242/#review132822
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 3074)
<https://reviews.apache.org/r/47242/#comment197075>

    It could have been. Feels cleaner to me as non-static. Just a matter of style. Is there
any advantage of keeping it static?



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 3168)
<https://reviews.apache.org/r/47242/#comment197077>

    yeah.. can remove that.


- Ashutosh Chauhan


On May 11, 2016, 4:36 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47242/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 4:36 p.m.)
> 
> 
> Review request for hive and Rui Li.
> 
> 
> Bugs: HIVE-13726
>     https://issues.apache.org/jira/browse/HIVE-13726
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> For insert overwrite significant amount might be spent in deleting existing files. This
patch parallelizes this task.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java 71c9188 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dd14124 
> 
> Diff: https://reviews.apache.org/r/47242/diff/
> 
> 
> Testing
> -------
> 
> existing regression tests. No change in functionality.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message