hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mohit Sabharwal <mo...@cloudera.com>
Subject Re: Review Request 47204: HIVE-13549 : Remove jdk version specific out files from Hive2
Date Wed, 11 May 2016 21:57:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47204/
-----------------------------------------------------------

(Updated May 11, 2016, 9:57 p.m.)


Review request for hive.


Changes
-------

Updated some more failures.


Bugs: HIVE-13549
    https://issues.apache.org/jira/browse/HIVE-13549


Repository: hive-git


Description
-------

HIVE-13549 : Remove jdk version specific out files from Hive2

This patch:
1) Removes the JAVA_VERSION_SPECIFIC_OUTPUT hint from q files
2) Removes the corresponding *java1.7.out and *java1.8.out golden files.
3) Regenerates the corresponding new q.out files

Note that in all cases, the java1.7.out version was more recent than java1.8.out
version, because the latter wwas not kept up to date with the changes.
Note: In some cases, three versions of out file existed (q.out, java1.7.out,
java1.8.out). So, in cases where you see diff in an existing golden file or 
differences between the new q.out file and it's java1.8.out file, it's that
file catching up to the java1.7.out version.

Note that the version specific hint and version specific files
remain for avro_timestamp_win.q. This is a windows specific golden
file. I will need to ping some other community member more familiar
with this test to regenerate.


Diffs (updated)
-----

  ql/src/test/queries/clientnegative/columnstats_partlvl_invalid_values.q 712ece7b7d24218e61aaaab909c9eb2025ce0965

  ql/src/test/queries/clientpositive/authorization_explain.q 6a9475cfc011e0e2403517b7a67c09129ed19569

  ql/src/test/queries/clientpositive/avro_date.q 15c07de0c256a6e317ab5386e90eaf8ee3b9b8fd

  ql/src/test/queries/clientpositive/avro_deserialize_map_null.q 962e649d2cd5149aec24d2020bbce986e321cc60

  ql/src/test/queries/clientpositive/avro_nullable_fields.q 9ba744178b6dc1a7f2e7a8294f8056a76889edc7

  ql/src/test/queries/clientpositive/avro_timestamp.q 7bf0dc8900e917ea5d84e534a66450218273893f

  ql/src/test/queries/clientpositive/cbo_rp_outer_join_ppr.q c497ce99624452797b93080aef6733d99bda48ff

  ql/src/test/queries/clientpositive/char_udf1.q 09012b450d3441a73d05f3c38fc6b25ec7f22e6d

  ql/src/test/queries/clientpositive/input4.q 83edbe2021803330e5a491160917f4f9df1b6baf 
  ql/src/test/queries/clientpositive/join0.q 66f2ef355a537e463f4da0128ed6894620f16b04 
  ql/src/test/queries/clientpositive/list_bucket_dml_10.q 5d3dade61d106023f2f2385643b268da3af0c5cf

  ql/src/test/queries/clientpositive/list_bucket_dml_11.q 2d22d6646c11a3bbec455f207babb8edb154ba7d

  ql/src/test/queries/clientpositive/list_bucket_dml_12.q ac063cc194eee468a1b20d9b1b39b1c216ce6f7a

  ql/src/test/queries/clientpositive/list_bucket_dml_13.q d68ca93845385688e095162c3b0d223f2847e812

  ql/src/test/queries/clientpositive/list_bucket_dml_2.q 263a002cd4db123f9c33217c61175681f0006b9f

  ql/src/test/queries/clientpositive/list_bucket_dml_4.q 86ff342e11117e4dc014399780800764f8277e23

  ql/src/test/queries/clientpositive/list_bucket_dml_5.q ace7ba95677db8905687be879262672c594b46ec

  ql/src/test/queries/clientpositive/list_bucket_dml_6.q 56847885eac30bde8df99b03dae319a6b4c439ac

  ql/src/test/queries/clientpositive/list_bucket_dml_8.q d90454332218b48f31aaf74299a4e86298c81409

  ql/src/test/queries/clientpositive/list_bucket_dml_9.q 620750cef5fe57ebdb59ac180dcfd397056df25a

  ql/src/test/queries/clientpositive/outer_join_ppr.q 497a4d1dc3c36bd78eca7c43410383885b756a97

  ql/src/test/queries/clientpositive/parquet_map_null.q 61058f319d3189eb5c68032548b4d97d65f133cc

  ql/src/test/queries/clientpositive/plan_json.q aa2b134fe238ef680cdfe80bff3eb26c6627b4bf

  ql/src/test/queries/clientpositive/stats_list_bucket.q 51137a81595f7b35f9ea5c3a99f09593bf5d534f

  ql/src/test/queries/clientpositive/str_to_map.q f2993b1780f5e488c009610650c3b45ffff11a6b

  ql/src/test/queries/clientpositive/subquery_multiinsert.q bea2e13f068374bcc8e1dd04b1bb8466dbdf3d98

  ql/src/test/queries/clientpositive/subquery_notin_having.q 8b2914d6eb0d753b32a6328f23f511895640a7ab

  ql/src/test/queries/clientpositive/varchar_udf1.q ff40b310dc0e6687f9db369cd452cb1b1860ead2

  ql/src/test/queries/clientpositive/vector_cast_constant.q c50dd8f4c6ba26ec5b18fcc7fb4536d4a2b39f15

  ql/src/test/results/clientnegative/columnstats_partlvl_invalid_values.q.java1.7.out 4ea70e3c9e7e63b7143d5cbf45251d7727d521f8

  ql/src/test/results/clientnegative/columnstats_partlvl_invalid_values.q.java1.8.out 7cae55e445f3b516bff697fa2f47cac1ba109291

  ql/src/test/results/clientnegative/columnstats_partlvl_invalid_values.q.out PRE-CREATION

  ql/src/test/results/clientpositive/authorization_explain.q.java1.7.out a9ed0495fcecadbddf1fcfb764e916fbb5406662

  ql/src/test/results/clientpositive/authorization_explain.q.java1.8.out b7ec20981a9322cedcfbdc8da5b1bf0946c98bfe

  ql/src/test/results/clientpositive/authorization_explain.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_date.q.java1.7.out 501b983a05917502e5f06c2cbed61d4240f4aa8f

  ql/src/test/results/clientpositive/avro_date.q.java1.8.out dea51c6b0d1603908e9518250032fa4d95c02f8b

  ql/src/test/results/clientpositive/avro_date.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_deserialize_map_null.q.java1.7.out 8f8065eebab04914b980a23637436a52bd2e0051

  ql/src/test/results/clientpositive/avro_deserialize_map_null.q.java1.8.out 127d8b3d37fe6bb14e981f7f8013d2f7e3dd7011

  ql/src/test/results/clientpositive/avro_deserialize_map_null.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_nullable_fields.q.java1.7.out 52b09d46ea18e58653c1a2224322861c0ce14460

  ql/src/test/results/clientpositive/avro_nullable_fields.q.java1.8.out 3690f7b2817afa1c36f4206fedb8751621c787af

  ql/src/test/results/clientpositive/avro_nullable_fields.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_timestamp.q.java1.7.out d2d3b7c6015cbd1eccbdddc164629750b6a9867e

  ql/src/test/results/clientpositive/avro_timestamp.q.java1.8.out 4c3834702bf3fb70422b3beefbf4e8053d47b983

  ql/src/test/results/clientpositive/avro_timestamp.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 5c40dc47bc537893d38004b4df0ddfa2f3b678ed

  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ee1c2aeb8cf8546b239ad4ed60f21853c21b5278

  ql/src/test/results/clientpositive/char_udf1.q.java1.8.out 5691a0636a2337556a6d691d60aa35ee2adb4d34

  ql/src/test/results/clientpositive/char_udf1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/input4.q.java1.7.out eaeedcb6d229b152e56aeedf3bc83f2fcf64ff73

  ql/src/test/results/clientpositive/input4.q.java1.8.out eaeedcb6d229b152e56aeedf3bc83f2fcf64ff73

  ql/src/test/results/clientpositive/input4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/join0.q.java1.7.out 343f8a413e58ac1883728add01162e73ae84acbf

  ql/src/test/results/clientpositive/join0.q.java1.8.out 343f8a413e58ac1883728add01162e73ae84acbf

  ql/src/test/results/clientpositive/join0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_10.q.java1.7.out 8447e860513bebe083714912560a88e74ba4ce08

  ql/src/test/results/clientpositive/list_bucket_dml_10.q.java1.8.out d1b9598d9033824dae9e185f1600620a7f605a8c

  ql/src/test/results/clientpositive/list_bucket_dml_10.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_11.q.java1.7.out b58d17c1e7b918fe9793ab36033cb02f36d14142

  ql/src/test/results/clientpositive/list_bucket_dml_11.q.java1.8.out 00a623544267ad23c62c36289ff5ee78ee2b26ce

  ql/src/test/results/clientpositive/list_bucket_dml_11.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.7.out 0be7f4e8c276d1f6fc68a4f3661c418637fbc16f

  ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.8.out 6d2298bcc481d3eaab41b7dec7a1e74cf0d5b655

  ql/src/test/results/clientpositive/list_bucket_dml_12.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.7.out bfce33500eb4c1d471b0a5e15791ab6be8edd682

  ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.8.out f7a103995ca037fc877853ef00e37e28cfe5f027

  ql/src/test/results/clientpositive/list_bucket_dml_13.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_2.q.java1.7.out dcfbec0423737c2fe2f326ce14a936807c416cab

  ql/src/test/results/clientpositive/list_bucket_dml_2.q.java1.8.out aeeba03f5b3bec34442ad148e2683c6e1822b58a

  ql/src/test/results/clientpositive/list_bucket_dml_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_4.q.java1.7.out c15c6a29273ecc60947a025bc96069d2f6b08d35

  ql/src/test/results/clientpositive/list_bucket_dml_4.q.java1.8.out d484626cbe454e343888082be44cddaa14fd6511

  ql/src/test/results/clientpositive/list_bucket_dml_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_5.q.java1.7.out a0947b21d03e20cc22d712d08d10d12b4f237815

  ql/src/test/results/clientpositive/list_bucket_dml_5.q.java1.8.out 1c33382b8d2bcfb5f2eb8daec4253b252fbb5a5b

  ql/src/test/results/clientpositive/list_bucket_dml_5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_6.q.java1.7.out c022618439ef7ef3b4c339339f227147357d615f

  ql/src/test/results/clientpositive/list_bucket_dml_6.q.java1.8.out 1960d4155bcfe69ccd227348365041667b829080

  ql/src/test/results/clientpositive/list_bucket_dml_6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.7.out d40a69340226cb15a5a695266eff0674422b518f

  ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.8.out 9947c1a14d43f0dcd0b45f0700f7bf225b5fe059

  ql/src/test/results/clientpositive/list_bucket_dml_8.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_dml_9.q.java1.7.out 752ea4e47ee7832b181814c00018de327cce2dea

  ql/src/test/results/clientpositive/list_bucket_dml_9.q.java1.8.out 599d3b000a000c4af21b178a8806ae62c1c258d9

  ql/src/test/results/clientpositive/list_bucket_dml_9.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/join0.q.java1.7.out 5651839c647a3de2ca29ba0c5fc5b93cb9cf507d

  ql/src/test/results/clientpositive/llap/join0.q.java1.8.out 5651839c647a3de2ca29ba0c5fc5b93cb9cf507d

  ql/src/test/results/clientpositive/llap/join0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/vector_cast_constant.q.java1.7.out 22b5d934876ae98bd5ccccf48e55c6de9da9403c

  ql/src/test/results/clientpositive/llap/vector_cast_constant.q.java1.8.out 22b5d934876ae98bd5ccccf48e55c6de9da9403c

  ql/src/test/results/clientpositive/llap/vector_cast_constant.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/outer_join_ppr.q.java1.7.out 1312e5388f1bc82b9b8cf13a198355fd1c24897b

  ql/src/test/results/clientpositive/outer_join_ppr.q.java1.8.out b9c1a66c1758b5207ba0e0461a520998981b5788

  ql/src/test/results/clientpositive/outer_join_ppr.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_map_null.q.java1.7.out 825e6680183fe212f8ae1ef699c3c86654c77b38

  ql/src/test/results/clientpositive/parquet_map_null.q.java1.8.out 1462cc216023cc00e9cbed31df53391b050d213f

  ql/src/test/results/clientpositive/parquet_map_null.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/plan_json.q.java1.7.out dda4adcd6f1cf1ffb8e7ff79b3fbf930b729d47b

  ql/src/test/results/clientpositive/plan_json.q.java1.8.out dda4adcd6f1cf1ffb8e7ff79b3fbf930b729d47b

  ql/src/test/results/clientpositive/plan_json.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/spark/join0.q.java1.7.out b3a58d02787cebe25e7437419fd284025cb888d9

  ql/src/test/results/clientpositive/spark/join0.q.java1.8.out 7acd1087e8e37dbe4ddfd82f0f20f0082b8a3c7b

  ql/src/test/results/clientpositive/spark/join0.q.out 56b154ff799097c78dc5d66a7b7cc3c303b88b00

  ql/src/test/results/clientpositive/spark/list_bucket_dml_10.q.java1.7.out 30405443a8b69f75295278aee1eb035d096cea49

  ql/src/test/results/clientpositive/spark/list_bucket_dml_10.q.java1.8.out 12f41eb7261e8bcb17cfccae74d79593d61c6c04

  ql/src/test/results/clientpositive/spark/list_bucket_dml_10.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/spark/list_bucket_dml_2.q.java1.7.out d8da70cb2e1d7e72535326ccc99a0fc4bf8200fa

  ql/src/test/results/clientpositive/spark/list_bucket_dml_2.q.java1.8.out 23dc6a3028b3d4169f622c46ba0ac35428449992

  ql/src/test/results/clientpositive/spark/list_bucket_dml_2.q.out 3ee9b5ae3f297df97c8c8fd71bf5231abac702d3

  ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.7.out 68943e1419cbeaafd630dea0944e523e71abba15

  ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.8.out c3454eee3e7ea512e31b39996f83ade8e77a3b8f

  ql/src/test/results/clientpositive/spark/outer_join_ppr.q.out 217fe76b8212020d6b0ff3f518e930521103f8d5

  ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.java1.7.out b43ea5cba519934ba8d69b95b56acf68d2239e79

  ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.java1.8.out 1bfdba20995aa48dc2981cefe553170a93431d67

  ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 04dd9b4630d0039620222da2907e2d51fa42784d

  ql/src/test/results/clientpositive/spark/vector_cast_constant.q.java1.7.out 86b7544fc853b17d373b8f8b9167a88a2e92eccd

  ql/src/test/results/clientpositive/spark/vector_cast_constant.q.java1.8.out 69f475440b8aabba9bc7005e6029de6565680967

  ql/src/test/results/clientpositive/spark/vector_cast_constant.q.out 63cdc2437ea5735d8b285ed52f6836fb6a45f4d9

  ql/src/test/results/clientpositive/stats_list_bucket.q.java1.7.out a4908bcf7912cc3fedbe15f6bfd5f3581fae3b16

  ql/src/test/results/clientpositive/stats_list_bucket.q.java1.8.out 8688cee49a966232014877bbd569833d7a595266

  ql/src/test/results/clientpositive/stats_list_bucket.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/str_to_map.q.java1.7.out 652acbb67755437f519b5e174d8425ca7d1c65ae

  ql/src/test/results/clientpositive/str_to_map.q.java1.8.out 23b0cbb33eb6bec217f79fd24ec6473726b55cac

  ql/src/test/results/clientpositive/str_to_map.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/subquery_multiinsert.q.java1.7.out 279843b4dd835e75e215387d8894429448b588a2

  ql/src/test/results/clientpositive/subquery_multiinsert.q.java1.8.out 899723f273a0eb7a6e47b12b7a25cb37e396def8

  ql/src/test/results/clientpositive/subquery_multiinsert.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 70f959150c58c85d65d958025dfbbf4dd80586dd

  ql/src/test/results/clientpositive/subquery_notin_having.q.java1.8.out 4e227cd9d02ba6f28d9295aaf03adf15b104a3d8

  ql/src/test/results/clientpositive/subquery_notin_having.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/join0.q.java1.7.out 59d90871364b963b097117bdc45eacdedd785c0f

  ql/src/test/results/clientpositive/tez/join0.q.java1.8.out 10d780200944dd96052c8ef989a211e225dfc4f0

  ql/src/test/results/clientpositive/tez/join0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/vector_cast_constant.q.java1.7.out 420e7881636338d1a829d4c2609498e6864cc23d

  ql/src/test/results/clientpositive/tez/vector_cast_constant.q.java1.8.out 331edd0296c8f8d94b2ed88b3d9867eb2feb4995

  ql/src/test/results/clientpositive/tez/vector_cast_constant.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 459d93b99d7c57108945db7d95bd612e33029900

  ql/src/test/results/clientpositive/varchar_udf1.q.java1.8.out ace85682bd9fe659e475464330a58d2e0b38ef74

  ql/src/test/results/clientpositive/varchar_udf1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/vector_cast_constant.q.java1.7.out 867dd4c96b9cd88a1fe6369f6307ab2d95ce5a84

  ql/src/test/results/clientpositive/vector_cast_constant.q.java1.8.out 789e6c2b82ffa473f2c8fd29ee9568f83243c2bf

  ql/src/test/results/clientpositive/vector_cast_constant.q.out 39ed1c85839c5b567bca603d335bf947b0a03b7f


Diff: https://reviews.apache.org/r/47204/diff/


Testing
-------


Thanks,

Mohit Sabharwal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message