hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 47185: HIVE-13716
Date Wed, 11 May 2016 16:14:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47185/#review132668
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 4161)
<https://reviews.apache.org/r/47185/#comment196944>

    yes.. we just deleted location in previous step, so it will be empty.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2679)
<https://reviews.apache.org/r/47185/#comment196945>

    yes.. name for destPath is chosen based on the assumption its a file



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2851)
<https://reviews.apache.org/r/47185/#comment196946>

    It may not be needed as of now. But I think its a good practice to set thread local variable
for each thread.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2854)
<https://reviews.apache.org/r/47185/#comment196947>

    correct.. i will update the logic.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2871)
<https://reviews.apache.org/r/47185/#comment196948>

    I think this is useful to force shut current existing threads.


- Ashutosh Chauhan


On May 10, 2016, 3:41 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47185/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 3:41 p.m.)
> 
> 
> Review request for hive and Rui Li.
> 
> 
> Bugs: HIVE-13716
>     https://issues.apache.org/jira/browse/HIVE-13716
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Parallelize setting file permissions for moveFile()
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java 71c9188 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c4d3bfb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java c2c6c65 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f4a9772 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java e931156 
> 
> Diff: https://reviews.apache.org/r/47185/diff/
> 
> 
> Testing
> -------
> 
> Existing regression tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message