hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rui Li <rui...@intel.com>
Subject Re: Review Request 47185: HIVE-13716
Date Wed, 11 May 2016 07:59:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47185/#review132610
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 4161)
<https://reviews.apache.org/r/47185/#comment196874>

    Here we choose non-recursive because location is an empty dir, right?



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2679)
<https://reviews.apache.org/r/47185/#comment196875>

    Are we sure destPath is always a file and not a dir?



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2851)
<https://reviews.apache.org/r/47185/#comment196880>

    I'm not sure if this is needed here. I set the session state in copyFiles because we need
to call needToCopy in each thread, which requires the session state to be set.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2854)
<https://reviews.apache.org/r/47185/#comment196881>

    Is it possible that the rename fails but no exception is thrown? If so, we will eventaully
return true, which is not correct.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2871)
<https://reviews.apache.org/r/47185/#comment196882>

    I guess this is redundant?


- Rui Li


On May 10, 2016, 3:41 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47185/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 3:41 p.m.)
> 
> 
> Review request for hive and Rui Li.
> 
> 
> Bugs: HIVE-13716
>     https://issues.apache.org/jira/browse/HIVE-13716
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Parallelize setting file permissions for moveFile()
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java 71c9188 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c4d3bfb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java c2c6c65 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f4a9772 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java e931156 
> 
> Diff: https://reviews.apache.org/r/47185/diff/
> 
> 
> Testing
> -------
> 
> Existing regression tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message