hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lefty Leverenz <leftylever...@gmail.com>
Subject Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP
Date Fri, 06 May 2016 00:00:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46579/#review131971
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2694 - 2698)
<https://reviews.apache.org/r/46579/#comment196012>

    My usual comment:  please spell out the abbreviations ZK and HS2 (at least once each)
for the benefit of newcomers.  Neither one comes up near the top of a google search.


- Lefty Leverenz


On May 5, 2016, 9:55 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46579/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 9:55 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bb74d99 
>   llap-client/pom.xml 50c06a4 
>   llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java 424769f 
>   llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClientFactory.java
PRE-CREATION 
>   llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java
PRE-CREATION 
>   llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java 18355e6 
>   llap-common/src/java/org/apache/hadoop/hive/llap/LlapUtil.java ce03de0 
>   llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapManagementProtocolClientImpl.java
cd11bdb 
>   llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java edf9b18

>   llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java e662de9

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java
db8bfa6 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java f958bc4

>   llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java c54e726

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fd6465a 
> 
> Diff: https://reviews.apache.org/r/46579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message