hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data
Date Tue, 03 May 2016 20:55:20 GMT


> On May 3, 2016, 3:14 p.m., Siddharth Seth wrote:
> > Looks good in terms of functionality. (Ship it if you think the reflection is not
super brittle :))
> > I think we should get rid of the reflection to access private methods ASAP though
- it can be really brittle and cause difficult to debug failures with different hadoop versions
- ideally before a 2.1 release.
> > 1) The perf issue may not be valid, and we could get away with using a single UGI.
> > 2) A UGI pool.
> > If this gets committed as is, could you please open a follow up blocker ticket for
2.1 to remove the reflection. I can take that up at a later point.

We'd only be able to remove reflection in newer versions of Hadoop, so it will still remain
in the shim, at least.
There's unfortunately no way to clone the UGI (that I see).
The problem with pools or a single UGI is that we cannot add credentials. Therefore, LLAP
won't work against anything other than HDFS (e.g. HBase, etc.) in this mode... Maybe there
should be a config flag for the case of bugs. However, I think UGI state is fairly stable,
esp. the ctor and the getters probably won't change. We should decide, cause if we don't want
reflection there's no point in committing this for now.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46754/#review131507
-----------------------------------------------------------


On May 2, 2016, 9:44 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46754/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 9:44 p.m.)
> 
> 
> Review request for hive and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/UgiFactory.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2814353 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
6981061 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
3d45c7a 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 63cb16b

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java
fcfa940 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java fea3dc7

>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java
b3b571d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java 76ba225

>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
24f4442 
>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java
08ee769 
> 
> Diff: https://reviews.apache.org/r/46754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message