hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
Date Tue, 03 May 2016 17:37:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46671/#review131529
-----------------------------------------------------------




metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3284)
<https://reviews.apache.org/r/46671/#comment195543>

    Should this be equalsIgnoreCase() ?



ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java (line 30)
<https://reviews.apache.org/r/46671/#comment195552>

    Please add javadocs for this class.



ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java (line 29)
<https://reviews.apache.org/r/46671/#comment195551>

    Please add javadoc for this class.



ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java (line
119)
<https://reviews.apache.org/r/46671/#comment195550>

    These words (primaryKeyInfo etc) should be identical across all formatters.



ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java (line
169)
<https://reviews.apache.org/r/46671/#comment195545>

    Detailed & Information are redundant. Just use Constraints



ql/src/test/queries/clientpositive/create_with_constraints.q (line 17)
<https://reviews.apache.org/r/46671/#comment195546>

    describe formatted should also print constraints info. can you add a test case for that
as well.
    Also for describe extended/formatted dbName.tblName;



ql/src/test/queries/clientpositive/create_with_constraints.q (line 19)
<https://reviews.apache.org/r/46671/#comment195549>

    Can you also add tests for describe formatted tblName colName; where colName is part of
constraint. This should print out constraints relevant for that column.



ql/src/test/results/clientpositive/create_with_constraints.q.out (line 116)
<https://reviews.apache.org/r/46671/#comment195547>

    There should be line break after Constraints Info



ql/src/test/results/clientpositive/create_with_constraints.q.out (line 137)
<https://reviews.apache.org/r/46671/#comment195548>

    I think words Qualified and  child are redundant here.


Schema changes look good. Other code related comments.

- Ashutosh Chauhan


On May 3, 2016, 3:46 a.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46671/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 3:46 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Describe extended table should show the primary keys/foreign keys associated with the
table
> 
> 
> Diffs
> -----
> 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa 
>   metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 
>   metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 
>   metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 
>   metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 
>   metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d 
>   metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 
>   metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c 
>   metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 
>   metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 
>   metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f

>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 
>   metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java 3806e28

>   metastore/src/model/package.jdo b40df39 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
75c2dd9 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b

>   ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
b5dc0b4 
>   ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 
>   ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 
> 
> Diff: https://reviews.apache.org/r/46671/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message