Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DDF0119A36 for ; Fri, 29 Apr 2016 04:42:22 +0000 (UTC) Received: (qmail 86049 invoked by uid 500); 29 Apr 2016 04:42:22 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 85967 invoked by uid 500); 29 Apr 2016 04:42:22 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 85954 invoked by uid 99); 29 Apr 2016 04:42:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 04:42:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D42992B40B7; Fri, 29 Apr 2016 04:42:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3123052815019025795==" MIME-Version: 1.0 Subject: Re: Review Request 46755: JDBC: Support query timeout for jdbc From: Thejas Nair To: Thejas Nair Cc: Vaibhav Gumashta , hive Date: Fri, 29 Apr 2016 04:42:16 -0000 Message-ID: <20160429044216.26196.7569@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Thejas Nair X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46755/ X-Sender: Thejas Nair References: <20160427231437.26196.5509@reviews.apache.org> In-Reply-To: <20160427231437.26196.5509@reviews.apache.org> Reply-To: Thejas Nair X-ReviewRequest-Repository: hive-git --===============3123052815019025795== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46755/#review131001 ----------------------------------------------------------- service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java (line 382) I think we should call this on any terminal state , except for TIMEOUT. - Thejas Nair On April 27, 2016, 11:14 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46755/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 11:14 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-4924 > https://issues.apache.org/jira/browse/HIVE-4924 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-4924 > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 965627f > itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java 4d763d2 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3cc6b74 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad43fb > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 0234fd9 > service-rpc/if/TCLIService.thrift 92bcf77 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 9f937ca > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 66f5e8c > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java 2eb4d09 > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java 3fa49b0 > service-rpc/src/gen/thrift/gen-php/Types.php 7f1f99f > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 3bb20b8 > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 7208bae > service/src/java/org/apache/hive/service/cli/CLIService.java 4a83e38 > service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 79e0024 > service/src/java/org/apache/hive/service/cli/ICLIService.java e4aef96 > service/src/java/org/apache/hive/service/cli/OperationState.java 6a67a1d > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java b3d9b52 > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java f18dc67 > service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 77228fa > service/src/java/org/apache/hive/service/cli/operation/Operation.java 63b1a48 > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 52e4b4d > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 01dd48c > service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9ea643b > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 0cfec7a > service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java b2e0e9e > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 6ede1d7 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 098aea6 > service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java 1740079 > service/src/test/org/apache/hive/service/cli/thrift/ThriftCliServiceTestWithCookie.java a1ef1fc > > Diff: https://reviews.apache.org/r/46755/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > > --===============3123052815019025795==--