Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 22FFC19223 for ; Tue, 26 Apr 2016 18:09:59 +0000 (UTC) Received: (qmail 7214 invoked by uid 500); 26 Apr 2016 18:09:53 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 7130 invoked by uid 500); 26 Apr 2016 18:09:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 7101 invoked by uid 99); 26 Apr 2016 18:09:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 18:09:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 69C892B25DB; Tue, 26 Apr 2016 18:09:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6548309741009456870==" MIME-Version: 1.0 Subject: Re: Review Request 46020: skip.header.line.count causes values to be skipped when performing insert values From: Vladislav Pavlenko To: hive , Ashutosh Chauhan , Vladislav Pavlenko Date: Tue, 26 Apr 2016 18:09:48 -0000 Message-ID: <20160426180948.26230.55361@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vladislav Pavlenko X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46020/ X-Sender: Vladislav Pavlenko References: <20160425171612.26196.91840@reviews.apache.org> In-Reply-To: <20160425171612.26196.91840@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/file_with_header_footer.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/file_with_header_footer.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientnegative/file_with_header_footer_negative.q Reply-To: Vladislav Pavlenko X-ReviewRequest-Repository: hive-git --===============6548309741009456870== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46020/ ----------------------------------------------------------- (Updated Апрель 26, 2016, 6:09 п.п.) Review request for hive. Changes ------- separate logic when footer or header = 0. Add some comments. Bugs: HIVE-10176 https://issues.apache.org/jira/browse/HIVE-10176 Repository: hive-git Description ------- When inserting values in to tables with TBLPROPERTIES ("skip.header.line.count"="1") the first value listed is also skipped1. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java a5489a9 ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java 6a407af ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 54592cc ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java ab0635e ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java 4a05a62 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce ql/src/test/queries/clientnegative/file_with_header_footer_negative.q 1f63d94 ql/src/test/queries/clientpositive/file_with_header_footer.q 8913e54 ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out 1794ae6 ql/src/test/results/clientpositive/file_with_header_footer.q.out ca3dadb ql/src/test/results/clientpositive/skiphf_aggr.q.out aeb4b1b Diff: https://reviews.apache.org/r/46020/diff/ Testing ------- All the 2 failures are not related: org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3 org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery. UPD: Now I don't create tmp file. Add methow that upload file in hdfs directly. Thanks, Vladislav Pavlenko --===============6548309741009456870==--