Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3497D19D32 for ; Sat, 23 Apr 2016 20:21:01 +0000 (UTC) Received: (qmail 89725 invoked by uid 500); 23 Apr 2016 20:21:00 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 89638 invoked by uid 500); 23 Apr 2016 20:21:00 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 89621 invoked by uid 99); 23 Apr 2016 20:21:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Apr 2016 20:21:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D12E52B2965; Sat, 23 Apr 2016 20:20:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8874175240767768857==" MIME-Version: 1.0 Subject: Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command From: Hari Sankar Sivarama Subramaniyan To: Ashutosh Chauhan Cc: Hari Sankar Sivarama Subramaniyan , pengcheng xiong , hive Date: Sat, 23 Apr 2016 20:20:55 -0000 Message-ID: <20160423202055.8135.63635@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Hari Sankar Sivarama Subramaniyan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45274/ X-Sender: Hari Sankar Sivarama Subramaniyan References: <20160423071752.8129.17918@reviews.apache.org> In-Reply-To: <20160423071752.8129.17918@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/test/queries/clientnegative/create_with_constraints_duplicate_name.q X-ReviewBoard-Diff-For: ql/src/test/results/clientnegative/create_with_constraints_validate.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/create_with_constraints.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/create_with_constraints.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientnegative/create_with_constraints_enable.q X-ReviewBoard-Diff-For: ql/src/test/results/clientnegative/create_with_constraints_duplicate_name.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientnegative/create_with_constraints_enable.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientnegative/create_with_constraints_validate.q Reply-To: Hari Sankar Sivarama Subramaniyan X-ReviewRequest-Repository: hive-git --===============8874175240767768857== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/ ----------------------------------------------------------- (Updated April 23, 2016, 8:20 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description ------- Support primary keys/foreign keys constraint as part of create table command in Hive Diffs (updated) ----- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ae6f084 ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 19342a8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a192fa7 ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 005b53f ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b ql/src/test/queries/clientnegative/create_with_constraints_duplicate_name.q PRE-CREATION ql/src/test/queries/clientnegative/create_with_constraints_enable.q PRE-CREATION ql/src/test/queries/clientnegative/create_with_constraints_validate.q PRE-CREATION ql/src/test/queries/clientpositive/create_with_constraints.q PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_duplicate_name.q.out PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_enable.q.out PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_validate.q.out PRE-CREATION ql/src/test/results/clientpositive/create_with_constraints.q.out PRE-CREATION Diff: https://reviews.apache.org/r/45274/diff/ Testing ------- Local testing done Thanks, Hari Sankar Sivarama Subramaniyan --===============8874175240767768857==--