Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7065F1902E for ; Tue, 19 Apr 2016 20:51:06 +0000 (UTC) Received: (qmail 52353 invoked by uid 500); 19 Apr 2016 20:51:05 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 52261 invoked by uid 500); 19 Apr 2016 20:51:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 52240 invoked by uid 99); 19 Apr 2016 20:51:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 20:51:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4F28D2B173A; Tue, 19 Apr 2016 20:51:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6668195584051747512==" MIME-Version: 1.0 Subject: Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for retrieving primary keys and foreign keys information From: Hari Sankar Sivarama Subramaniyan To: Ashutosh Chauhan Cc: Hari Sankar Sivarama Subramaniyan , Thejas Nair , hive , Carl Steinbach Date: Tue, 19 Apr 2016 20:51:01 -0000 Message-ID: <20160419205101.8135.21415@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Hari Sankar Sivarama Subramaniyan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44031/ X-Sender: Hari Sankar Sivarama Subramaniyan References: <20160329001130.30713.21106@reviews.apache.org> In-Reply-To: <20160329001130.30713.21106@reviews.apache.org> X-ReviewBoard-Diff-For: service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java X-ReviewBoard-Diff-For: service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java Reply-To: Hari Sankar Sivarama Subramaniyan X-ReviewRequest-Repository: hive-git --===============6668195584051747512== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44031/ ----------------------------------------------------------- (Updated April 19, 2016, 8:50 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description ------- HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files. Diffs (updated) ----- jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f service-rpc/if/TCLIService.thrift aa28b6e service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2 service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18 service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 0f36cd6 service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java e789a38 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc Diff: https://reviews.apache.org/r/44031/diff/ Testing ------- Thanks, Hari Sankar Sivarama Subramaniyan --===============6668195584051747512==--