Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 478C91960B for ; Sun, 3 Apr 2016 18:09:53 +0000 (UTC) Received: (qmail 62595 invoked by uid 500); 3 Apr 2016 18:09:52 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 62520 invoked by uid 500); 3 Apr 2016 18:09:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 62504 invoked by uid 99); 3 Apr 2016 18:09:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Apr 2016 18:09:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1CA0C2A57BF; Sun, 3 Apr 2016 18:09:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1138121885107332022==" MIME-Version: 1.0 Subject: Review Request 45658: HIVE-13373 : Use most specific type for numerical constants From: Ashutosh Chauhan To: Jason Dere Cc: Ashutosh Chauhan , hive Date: Sun, 03 Apr 2016 18:09:50 -0000 Message-ID: <20160403180950.20106.24913@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Chauhan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45658/ X-Sender: Ashutosh Chauhan Reply-To: Ashutosh Chauhan X-ReviewRequest-Repository: hive-git --===============1138121885107332022== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45658/ ----------------------------------------------------------- Review request for hive and Jason Dere. Bugs: HIVE-13373 https://issues.apache.org/jira/browse/HIVE-13373 Repository: hive-git Description ------- Currently integer & tinyint/bigint comparisons happen in double. They should happen in integer instead. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 45dfd27 ql/src/test/queries/clientpositive/type_widening.q b504cf9 ql/src/test/results/clientpositive/infer_const_type.q.out bd42f05 ql/src/test/results/clientpositive/spark/vectorization_0.q.out aeb6fb8 ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out e9fb1e8 ql/src/test/results/clientpositive/tez/vectorization_0.q.out c790578 ql/src/test/results/clientpositive/tez/vectorization_short_regress.q.out 32fdef6 ql/src/test/results/clientpositive/type_widening.q.out 84e53f8 ql/src/test/results/clientpositive/vectorization_0.q.out 53dffed ql/src/test/results/clientpositive/vectorization_short_regress.q.out 91c10f0 Diff: https://reviews.apache.org/r/45658/diff/ Testing ------- New test & regression suite. Thanks, Ashutosh Chauhan --===============1138121885107332022==--