hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pengcheng xiong <pxi...@hortonworks.com>
Subject Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
Date Fri, 22 Apr 2016 18:06:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45274/#review130137
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 792)
<https://reviews.apache.org/r/45274/#comment193802>

    could u please change the comments as well?



ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g (line 1996)
<https://reviews.apache.org/r/45274/#comment193810>

    IMHO, this is a little bit verbose. Now we have 8 branches for 2^3 combinations... For
example, The options for relySpec are only "rely" and "noreply", we can make them keywords
but not reserved ones. Then we have "^(TOK_RELY) replyOption ^(TOK_DISABLE) disableOption
^(TOK_NOVALIDATE)" noValidateOption". The parser can try to match the grammer automatically
and we do not need TOK_INVALID_KEY_SPEC any more.



ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g (line 2028)
<https://reviews.apache.org/r/45274/#comment193812>

    similar. We can make constraint a keyword but not a reserved one.


- pengcheng xiong


On April 20, 2016, 12:20 a.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45274/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 12:20 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support primary keys/foreign keys constraint as part of create table command in Hive
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 19342a8 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 96df189 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b 
> 
> Diff: https://reviews.apache.org/r/45274/diff/
> 
> 
> Testing
> -------
> 
> Local testing done
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message