hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 45911: HIVE-13341: Stats state is not captured correctly: differentiate load table and create table
Date Thu, 21 Apr 2016 00:14:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45911/#review129843
-----------------------------------------------------------



Can you update RB with full patch?


ql/src/test/results/clientpositive/stats12.q.out (lines 327 - 330)
<https://reviews.apache.org/r/45911/#comment193374>

    This loooks incorrect. We ran analyze statement for column stats but not on this partition.



ql/src/test/results/clientpositive/stats13.q.out (lines 239 - 241)
<https://reviews.apache.org/r/45911/#comment193375>

    This also looks incorrect.


- Ashutosh Chauhan


On April 14, 2016, 11:52 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45911/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 11:52 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-13341: Stats state is not captured correctly: differentiate load table and create
table
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 41d150c 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
c046708 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 76220f4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 54592cc 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 87a7667 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java eaeb66b 
>   ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q PRE-CREATION

>   ql/src/test/results/clientpositive/insert_values_orig_table_use_metadata.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/join32.q.out 5cb124b 
>   ql/src/test/results/clientpositive/stats0.q.out 99326fc 
>   ql/src/test/results/clientpositive/stats1.q.out 72c53e3 
>   ql/src/test/results/clientpositive/stats10.q.out d7519af 
>   ql/src/test/results/clientpositive/stats11.q.out 7598dc0 
>   ql/src/test/results/clientpositive/stats12.q.out 6a44d15 
>   ql/src/test/results/clientpositive/stats13.q.out f98753e 
>   ql/src/test/results/clientpositive/stats16.q.out 3b371a8 
>   ql/src/test/results/clientpositive/stats18.q.out 6971e44 
>   ql/src/test/results/clientpositive/stats20.q.out d7e52b4 
>   ql/src/test/results/clientpositive/stats3.q.out 0d8cbbd 
>   ql/src/test/results/clientpositive/stats5.q.out 74ddadb 
>   ql/src/test/results/clientpositive/stats6.q.out f2a756f 
>   ql/src/test/results/clientpositive/stats_noscan_1.q.out 7382b31 
>   ql/src/test/results/clientpositive/stats_partscan_1_23.q.out ab2baaa 
> 
> Diff: https://reviews.apache.org/r/45911/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message