hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vaibhav Gumashta <vgumas...@hortonworks.com>
Subject Re: Review Request 45836: JDBC: async wait should happen during fetch for results
Date Mon, 11 Apr 2016 18:00:41 GMT


> On April 11, 2016, 10:54 a.m., Vaibhav Gumashta wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 225
> > <https://reviews.apache.org/r/45836/diff/1-2/?file=1328876#file1328876line225>
> >
> >     I think you saw the difference between diff 1 and diff 2. You won't see this
in a diff between original and patch 2.
> 
> Thejas Nair wrote:
>     The patch 1 had a resultset.close added in Statement.close() . Shouldn't that change
be retained ?

Sorry missed that. Updated the patch.


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review128093
-----------------------------------------------------------


On April 11, 2016, 12:05 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:05 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
>     https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 4eaff10 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec1

>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52

>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62

>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280

>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
a09b39a 
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b851

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java b7d6549 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 9ce6055 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message