hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thejas Nair <the...@hortonworks.com>
Subject Re: Review Request 45836: JDBC: async wait should happen during fetch for results
Date Sat, 09 Apr 2016 04:43:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127953
-----------------------------------------------------------




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 
<https://reviews.apache.org/r/45836/#comment191340>

    shouldn't resultset be closed here ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 257)
<https://reviews.apache.org/r/45836/#comment191341>

    mark as @limitedprivate and @evolving ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 259)
<https://reviews.apache.org/r/45836/#comment191342>

    add a note that - users should call those getUpdateCount or ResultSet.next (depending
on whether query returns results) to ensure that query completes successfully.
    Calling another execute* method, or close before query completion would result in the
async query getting killed if it is not already finished.



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 312)
<https://reviews.apache.org/r/45836/#comment191343>

    getUpdateCount or ResultSet.next() would result in another RPC call. 
    Can we call keep track of the Statement complete status as a Statement member to avoid
that ?



service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 208)
<https://reviews.apache.org/r/45836/#comment191344>

    just use the condition directly here ?
    
    - if( !states.contains(state) ) {
    ... 
    }


- Thejas Nair


On April 9, 2016, 12:37 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 12:37 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
>     https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -----
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec1

>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52

>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62

>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280

>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
a09b39a 
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b851

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message