hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thejas Nair <the...@hortonworks.com>
Subject Re: Review Request 45836: JDBC: async wait should happen during fetch for results
Date Thu, 07 Apr 2016 06:24:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127559
-----------------------------------------------------------




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 
<https://reviews.apache.org/r/45836/#comment190929>

    these comments look still applicable and useful for someone new to the codebase. retain
them ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 824)
<https://reviews.apache.org/r/45836/#comment190941>

    why is this waitfor.. needed here ?



service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java (line 71)
<https://reviews.apache.org/r/45836/#comment190943>

    For MetadataOperation such as GetCatalogsOperation, in the blocking call the state moves
to FINISHED, as there is no async execution for it. So I this should assert for FINISHED state.



service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 205)
<https://reviews.apache.org/r/45836/#comment190946>

    states.contains(state) ?


- Thejas Nair


On April 6, 2016, 8:53 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 8:53 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
>     https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -----
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec1

>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52

>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62

>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280

>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
a09b39a 
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b851

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message