hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
Date Mon, 04 Apr 2016 23:11:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review126950
-----------------------------------------------------------




metastore/if/hive_metastore.thrift (line 53)
<https://reviews.apache.org/r/45406/#comment190033>

    We don't use term schema that much in Hive. So, its better to call it db



metastore/if/hive_metastore.thrift (line 61)
<https://reviews.apache.org/r/45406/#comment190034>

    Similar comment to use db instead of schema.



metastore/if/hive_metastore.thrift (line 302)
<https://reviews.apache.org/r/45406/#comment190036>

    its better to mark new fields as optional param for better compat.



metastore/if/hive_metastore.thrift (line 1215)
<https://reviews.apache.org/r/45406/#comment190037>

    We should follow request/response pattern for these api design. e.g, get_aggr_stats_for()



metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (lines 4 - 6)
<https://reviews.apache.org/r/45406/#comment190078>

    Instead of storing name, type and comment. We should just only store CS_ID with not null
constraint here.



metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 7)
<https://reviews.apache.org/r/45406/#comment190079>

    We also need to store constraint name.



metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 8)
<https://reviews.apache.org/r/45406/#comment190080>

    Also, it will be good to add index for this table on CS_ID



metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 13)
<https://reviews.apache.org/r/45406/#comment190082>

    There should be an index on this table on constraint_name.



metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 21)
<https://reviews.apache.org/r/45406/#comment190083>

    Index on constraint name.



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (lines 1819 -
1821)
<https://reviews.apache.org/r/45406/#comment190084>

    These joins could be expensive.



metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java (line 2601)
<https://reviews.apache.org/r/45406/#comment190085>

    We need to implement these methods.



metastore/src/model/package.jdo (line 151)
<https://reviews.apache.org/r/45406/#comment190086>

    Its better to store PKeys in COLUMNS_V2 and thus we can avoid a join.


- Ashutosh Chauhan


On April 4, 2016, 8:45 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 8:45 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
> 
> 
> Diffs
> -----
> 
>   metastore/if/hive_metastore.thrift 6a55962 
>   metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION 
>   metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 
>   metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c 
>   metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 
>   metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 
>   metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION 
>   metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 
>   metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 
>   metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION 
>   metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be 
>   metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 
>   metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION 
>   metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 
>   metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab

>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78

>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb 
>   metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9 
>   metastore/src/model/package.jdo 7385a13 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
94ca835 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
b108f95 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java
922a4bf 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java
6cd3a46 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java
e0c4094 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java
f4e55ed 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java
62918be 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6

>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java
b1dc542 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java
cfe9cd0 
> 
> Diff: https://reviews.apache.org/r/45406/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message