hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Review Request 45658: HIVE-13373 : Use most specific type for numerical constants
Date Sun, 03 Apr 2016 18:09:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45658/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Bugs: HIVE-13373
    https://issues.apache.org/jira/browse/HIVE-13373


Repository: hive-git


Description
-------

Currently integer & tinyint/bigint comparisons happen in double. They should happen in
integer instead.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 45dfd27 
  ql/src/test/queries/clientpositive/type_widening.q b504cf9 
  ql/src/test/results/clientpositive/infer_const_type.q.out bd42f05 
  ql/src/test/results/clientpositive/spark/vectorization_0.q.out aeb6fb8 
  ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out e9fb1e8 
  ql/src/test/results/clientpositive/tez/vectorization_0.q.out c790578 
  ql/src/test/results/clientpositive/tez/vectorization_short_regress.q.out 32fdef6 
  ql/src/test/results/clientpositive/type_widening.q.out 84e53f8 
  ql/src/test/results/clientpositive/vectorization_0.q.out 53dffed 
  ql/src/test/results/clientpositive/vectorization_short_regress.q.out 91c10f0 

Diff: https://reviews.apache.org/r/45658/diff/


Testing
-------

New test & regression suite.


Thanks,

Ashutosh Chauhan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message