Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============8927446503532462008=="
MIME-Version: 1.0
Subject: Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift
 interface for query results
From: Sergey Shelukhin <sergey@hortonworks.com>
To: Sergey Shelukhin <sergey@hortonworks.com>,
 Takanobu Asanuma <tasanuma@yahoo-corp.jp>, hive <dev@hive.apache.org>
Date: Fri, 18 Mar 2016 17:57:49 -0000
Message-ID: <20160318175749.10293.41711@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Sergey Shelukhin <noreply@reviews.apache.org>
References: <20160316085153.1703.81854@reviews.apache.org>
In-Reply-To: <20160316085153.1703.81854@reviews.apache.org>
Reply-To: Sergey Shelukhin <sergey@hortonworks.com>

--===============8927446503532462008==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40867/#review124234
-----------------------------------------------------------


jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 210)
<https://reviews.apache.org/r/40867/#comment186691>

    nit: whitespace


ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1917)
<https://reviews.apache.org/r/40867/#comment186693>

    why cannot the conf itself be passed in? why is the map necessary?
    Or, if that doesn't work for some reason, what about creating a small struct class to hold the fields with logical names and types, instead of the map.


- Sergey Shelukhin


On March 16, 2016, 8:51 a.m., Takanobu Asanuma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40867/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 8:51 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is a WIP patch for HIVE-11527
> 
> * I added a new configuration whose name is hive.server2.webhdfs.bypass.enabled. The default is false. When this value is true, clients use the bypass.
> 
> * I still have not considered security such as Kerberos and SSL at present.
> 
> * I have not implement Statement#setFetchSize for bypass yet.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 98c6372 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 7327a42 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 0b0c336 
>   service-rpc/if/TCLIService.thrift aa28b6e 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60 
>   service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java 31472c8 
>   service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java 7101fa5 
>   service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java 1aa3f94 
>   service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java 14d50ed 
>   service-rpc/src/gen/thrift/gen-php/Types.php b7df50a 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781 
>   service-rpc/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c 
>   service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2 
>   service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04d816a 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 8baecdf 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5 
> 
> Diff: https://reviews.apache.org/r/40867/diff/
> 
> 
> Testing
> -------
> 
> I have tested few simple queries and they worked well. But I think there are some problems for some queries. I'm going to test more queries and fix bugs. I'm also going to add unit tests.
> 
> 
> Thanks,
> 
> Takanobu Asanuma
> 
>


--===============8927446503532462008==--