Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2614F1872F for ; Sat, 5 Mar 2016 04:20:31 +0000 (UTC) Received: (qmail 74758 invoked by uid 500); 5 Mar 2016 04:20:30 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 74222 invoked by uid 500); 5 Mar 2016 04:20:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 74195 invoked by uid 99); 5 Mar 2016 04:20:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Mar 2016 04:20:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D332E2E850F; Sat, 5 Mar 2016 04:20:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5605347802434419911==" MIME-Version: 1.0 Subject: Re: Review Request 44271: HIVE-12270 : Add DBTokenStore support to HS2 delegation token From: Chaoyu Tang To: Szehon Ho , hive , Chaoyu Tang Date: Sat, 05 Mar 2016 04:20:28 -0000 Message-ID: <20160305042028.1649.80004@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chaoyu Tang X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44271/ X-Sender: Chaoyu Tang References: <20160304142519.7389.55026@reviews.apache.org> In-Reply-To: <20160304142519.7389.55026@reviews.apache.org> X-ReviewBoard-Diff-For: itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithDBTokenStore.java Reply-To: Chaoyu Tang X-ReviewRequest-Repository: hive-git --===============5605347802434419911== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44271/ ----------------------------------------------------------- (Updated March 5, 2016, 4:20 a.m.) Review request for hive. Changes ------- Revised the patch to getMSC via ThreadLocal Hive object for token api calls in each thread. Bugs: HIVE-12270 https://issues.apache.org/jira/browse/HIVE-12270 Repository: hive-git Description ------- Add HMS APIs to support DB delegation token in HS2. Only upload the patch without other thrift generated files for review here. Diffs (updated) ----- itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/MiniHiveKdc.java dedbf35 itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithDBTokenStore.java PRE-CREATION itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java 3ef2ce3 itests/hive-unit/src/test/java/org/apache/hadoop/hive/thrift/TestDBTokenStore.java f5934ee metastore/if/hive_metastore.thrift a4fb612 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 984e3fc metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java b5c4d1d metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cb092d1 service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 3d5e3a4 shims/common/src/main/java/org/apache/hadoop/hive/thrift/DBTokenStore.java de39d3d shims/common/src/main/java/org/apache/hadoop/hive/thrift/HiveDelegationTokenManager.java 9ecb0ee Diff: https://reviews.apache.org/r/44271/diff/ Testing ------- Manuall tests New Unit test TestJdbcWithDBToken Precommit tests Thanks, Chaoyu Tang --===============5605347802434419911==--